[hotfix] Fix build break with #7537 #7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufengwangca
approved these changes
Jun 16, 2021
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
mspang
approved these changes
Jun 16, 2021
|
#7678 ? |
hotfix doesn't work anymore? |
I'm not understanding the logic behind what status are always required now. It seems to be some examples/platforms but not others. Having at least the ability to unilaterally revert seems useful. |
yunhanw-google
approved these changes
Jun 16, 2021
|
Hotfix works fine? my question was - which approach are we taking? |
|
Note, it looks like this broke it: #7537 |
woody-apple
changed the title
I was not able to submit this PR without waiting for a subset of the checks in queue. |
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Per @yunhanw-google this appears to fix the build, force merging in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#7598 need to run codegen since template is changed before it is merged.
Change overview
Run codegen for #7598
Testing