Controller: Add other mdns filters #7659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mdns exposes serveral subtypes that can be used to narrow the dnssd search parameters. Previously, the only exposed parameter was the long discriminator, because it was used in the QR code. Adding others. Also changes the controller API function to take the filter structure directly, and uses the python script binding to set the filters as required. Test: Tested with M5 in commissionable mode / chip-device-ctrl - discover usage (discover with no args) - discover -all - discover -qr with good and bad qr - all variants with good and bad values verified all args with correct values return data, all args with bad arguments return no results.
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
woody-apple
approved these changes
Jun 15, 2021
msandstedt
reviewed
Jun 15, 2021
| # x number of responses are received. For now, just 2 seconds. We can all wait that long. | ||
| print("Waiting for device responses...") | ||
| time.sleep(2) | ||
|
|
||
| def do_discover(self, line): |
There was a problem hiding this comment.
Although not merged, #7432 has introduced use of argparse to remove the need for all this boilerplate just to define the args interface.
This PR is expanding the number of arguments for do_discover from 2 to 8, so is nearly a complete refactor. Given this, would you consider using argparse as well here? It's just a whole lot easier.
There was a problem hiding this comment.
Changed over in next commit. I'm not going to tackle any other refactors in this PR. I suppose this is ok - it's a bit longer, but does essentially the same thing.
|
/rebase |
andy31415
approved these changes
Jun 16, 2021
bzbarsky-apple
approved these changes
Jun 16, 2021
msandstedt
approved these changes
Jun 16, 2021
|
/rebase |
woody-apple
force-pushed
the
mdns_more_filters
branch
from
79f922f to
d40417f
Compare
|
/rebase |
cecille
force-pushed
the
mdns_more_filters
branch
from
d40417f to
941c58a
Compare
|
/rebase |
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Controller: Add other mdns filters Mdns exposes serveral subtypes that can be used to narrow the dnssd search parameters. Previously, the only exposed parameter was the long discriminator, because it was used in the QR code. Adding others. Also changes the controller API function to take the filter structure directly, and uses the python script binding to set the filters as required. Test: Tested with M5 in commissionable mode / chip-device-ctrl - discover usage (discover with no args) - discover -all - discover -qr with good and bad qr - all variants with good and bad values verified all args with correct values return data, all args with bad arguments return no results. * Fix function name in connect qr * use argparse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Mdns exposes serveral subtypes that can be used to narrow the dnssd
search parameters. Previously, the only exposed parameter was the
long discriminator, because it was used in the QR code.
Fixes #6691
Change overview
Adding remaining commisisonable nodes discovery filters.
Also changes the controller API function to take the filter structure
directly, and uses the python script binding to set the filters
as required.
Testing
Tested with M5 in commissionable mode / chip-device-ctrl
verified all args with correct values return data, all args with bad arguments return no results.