-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform impl for commissionable node discovery #7633
Platform impl for commissionable node discovery #7633
Conversation
(cecille): These need to be changed to remove leading zerosconnectedhomeip/src/lib/mdns/tests/TestServiceNaming.cpp Lines 158 to 168 in e6502ef
This comment was generated by todo based on a
|
add tests for longer vendor codes once the leading zero issue is fixed.connectedhomeip/src/lib/mdns/tests/TestServiceNaming.cpp Lines 195 to 205 in e6502ef
This comment was generated by todo based on a
|
Add tests for longer device types once the leadng zero issue is fixed.connectedhomeip/src/lib/mdns/tests/TestServiceNaming.cpp Lines 202 to 212 in e6502ef
This comment was generated by todo based on a
|
Size increase report for "gn_qpg6100-example-build" from b0eeffc
Full report output
|
Size increase report for "nrfconnect-example-build" from b0eeffc
Full report output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits, but looking good overall.
/rebase |
@@ -339,6 +340,8 @@ static void TestDNSResolution_NoHostRecord(nlTestSuite * testSuite, void * testC | |||
false | |||
} | |||
); | |||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: align #endif with above?
Not sure if this would be fighting the autoformatter :( looks odd though.
* Platform impl for commissionable node discovery * Address review comments from Damian
Problem
Currently there is no platform implementation for commissionable node discovery.
Fixes #6693
Change overview
Add platform implementation for commissionable node discovery
Testing
Tested with M5 + chip-device-ctrl compiled with chip_mdns platform.