Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inserting VP into txtFields in Advertiser_ImplMinimalMdns #7572

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

sharadb-amazon
Copy link
Contributor

Problem

  • VP was not being inserted into the array of txtFields in the mDNS Advertiser
  • VendorId's presence was not being checked before setting the value of VP

Change overview

Inserted VP's value into txtFields and checked vendorId's presence

Testing

  • Tested by running chip-lighting-app for linux and querying using avahi-browse -ar to see that VP field is advertised now.

@github-actions
Copy link

Size increase report for "esp32-example-build" from e250a8c

File Section File VM
chip-all-clusters-app.elf .flash.text 28 28
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_line,0,114
.debug_loc,0,86
.flash.text,28,28
.debug_ranges,0,8
.debug_info,0,-2
.debug_str,0,-2


@andy31415 andy31415 merged commit 1e546a1 into project-chip:master Jun 14, 2021
@sharadb-amazon sharadb-amazon deleted the mdns-txt-fix branch August 25, 2021 22:04
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants