Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle 03 large weave merge #757

Closed
wants to merge 61 commits into from
Closed

Restyle 03 large weave merge #757

wants to merge 61 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented May 19, 2020

A duplicate of #756 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

Only added WeaveConnection and extracted the WeaveConnection class
definition from MessageLayer.h

Separate commit so that we can track changes to the file in a clearer
manner.
This should have renamed includes and class members to convert
weave to chip.
- Added minimal necessary constaants for CHIPConnection.
- Removed Secure connection handling
- Removed auth settings except unauthenticated
Reasoning is that UDP is connectionless, so we use "exchange" to denote
exchanging messages.

Future CHIPConnection will actually handle connection protocols (tcp,
ble).
This is a copy of WeaveFabricState with automated weave->chip renaming
scripting.
@woody-apple
Copy link
Contributor

@rwalker-apple can we help @andy31415 perhaps clean up either what restyle is doing, or do this in a different way?

@rwalker-apple
Copy link
Contributor

@rwalker-apple can we help @andy31415 perhaps clean up either what restyle is doing, or do this in a different way?

is there a specific issue with what restyled has done?

@woody-apple
Copy link
Contributor

@rwalker-apple ... eep, maybe I'm out of date. @andy31415 was the shell-harden stuff still breaking your shell script?

@restyled-io restyled-io bot closed this Jun 1, 2020
@restyled-io restyled-io bot deleted the restyled/pull-756 branch June 1, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants