-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle 03 large weave merge #757
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only added WeaveConnection and extracted the WeaveConnection class definition from MessageLayer.h Separate commit so that we can track changes to the file in a clearer manner.
This should have renamed includes and class members to convert weave to chip.
- Added minimal necessary constaants for CHIPConnection. - Removed Secure connection handling - Removed auth settings except unauthenticated
… bindings give out compile errors
…nto the ChipConnectionContext
…r the communication channel
Reasoning is that UDP is connectionless, so we use "exchange" to denote exchanging messages. Future CHIPConnection will actually handle connection protocols (tcp, ble).
This is a copy of WeaveFabricState with automated weave->chip renaming scripting.
…l encryption/auth bits
…fabric state. Fabric compiles
…k yet though because DRBG_get_bytes.
… udp receive will be done by 'self' now
restyled-io
bot
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
May 19, 2020 17:53
@rwalker-apple can we help @andy31415 perhaps clean up either what restyle is doing, or do this in a different way? |
is there a specific issue with what restyled has done? |
@rwalker-apple ... eep, maybe I'm out of date. @andy31415 was the shell-harden stuff still breaking your shell script? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #756 with additional commits that automatically address
incorrect style, created by Restyled.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.