Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Limit OpenThread CLI buffers as RAM optimization #7451

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

tima-q
Copy link
Contributor

@tima-q tima-q commented Jun 8, 2021

Problem

OpenThread default CLI buffer sizes are not required for Thread debug actions done within the Matter examples.

Change overview

  • Reduced CLI sizes to reduce RAM overhead of CLI interface.
  • 640 bytes static RAM freed

Testing

  • Checked RAM usage decrease by comparison of compilation QPG6100 lighting-app before/after changes
  • Performed typical debug commands - 'help', 'state', 'ipaddr', ...
  • Internal automated test using OT CLI itf ran - join with commissioner, receive a ping

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Size increase report for "gn_qpg6100-example-build" from 2183830

File Section File VM
chip-qpg6100-lighting-example.out .heap 0 640
chip-qpg6100-lighting-example.out .bss 0 -640
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.heap,640,0
.bss,-640,0

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@bukepo
Copy link
Contributor

bukepo commented Jun 8, 2021

Is QPG6100 going to migrate to the new OpenThread CLI API?. It doesn't require such a buffer any more.

@andy31415 andy31415 merged commit 6a99148 into project-chip:master Jun 9, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@tima-q tima-q deleted the qpg6100/otcli_buffers branch October 5, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants