Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct stuff that differs from the spec in pump device and pump controller device #7396

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

janusheide
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Pump device and Pump Controller Device deviated from spec

Change overview

Changes to a few attributes to aling with the spec

Testing

How was this tested? (at least one bullet point required)

  • with existing CI

@boring-cyborg boring-cyborg bot added the app label Jun 4, 2021
@janusheide janusheide changed the title correct stuff that differs from the spec correct stuff that differs from the spec in pump device and pump controller device Jun 4, 2021
@andy31415
Copy link
Contributor

andy31415 commented Jun 4, 2021

@janusheide for the "tested with existing CI" - could you be more specific? This does not change any C++ code, so existing CI is unlikely to test anything here.

I am asking because I am looking to estimate how many of our PRs would fall under "has automated tests" vs "manual only" vs "cannot be tested at all". This PR seems to be the latter (cannot be tested, xml only) but comment seems to imply "has automated tests".

@janusheide
Copy link
Contributor Author

please see this merged PR, where I originally wrote that there was no tests (since there are no explicit tests) #7224 this is a device instead of a cluster, but it is a bit difficult to know what you are supposed to write under that test section when working on these xml files.

since this commit did not change any generate code, I guess it should be cannot be tested.

@woody-apple
Copy link
Contributor

@saurabhst @andy31415 ?

@woody-apple woody-apple merged commit 0ec85e6 into project-chip:master Jun 4, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants