Centralize JNI util functions in JniReferences and use GetEnvForCurrentThread() everywhere #7345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst,
vidhis88,
vivien-apple and
woody-apple
woody-apple
approved these changes
Jun 3, 2021
saurabhst
approved these changes
Jun 4, 2021
jmartinez-silabs
approved these changes
Jun 4, 2021
|
/rebase |
…rentThread everywhere.
woody-apple
force-pushed
the
jni-references
branch
from
fd34cc3 to
ea1f146
Compare
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…rentThread everywhere. (project-chip#7345)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Common code accessing
JavaVMandJNIEnvis duplicated inCHIPDeviceController-JNI,AndroidDeviceControllerWrapper, andAndroidKeyValueStoreManager. Before adding more duplication when another JNI file is generated for clusters, we should consolidate these references.Change overview
GetEnvForCurrentThread()fromAndroidKeyValueStoreManagertoJniReferencesGetEnvForCurrentThread()to attach thread as a daemon, which means we don't have to detach it manually.FindMethod()andCallVoidInt()fromAndroidDeviceControllerWrappertoJniReferencesJNIEnvis requested, useGetEnvForCurrentThread()to ensure theJNIEnvused won't be null.Testing
GetEnvForCurrentThread()invocation attaches to the new thread