Stop passing around reliable message managers when we don't need to

[bzbarsky-apple]

Problem

What is being fixed? We are passing around and storing reliable message manager pointers when we don't really need to.

Change overview

Get the reliable message manager from the reliable message context in the one place where we need it.

Testing

There should be no behavior changes here, just simpler and smaller code, so nothing to test other than that nothing breaks. I expect out CI to do that.

[github-actions]

Size increase report for "nrfconnect-example-build" from b5eade0

File	Section	File	VM
chip-lock.elf	device_handles	-4	-4
chip-lock.elf	text	-12	-12
chip-lock.elf	bss	0	-32
chip-shell.elf	text	16	16

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.strtab,0,68
.symtab,0,32
.debug_frame,0,-4
device_handles,-4,-4
text,-12,-12
.debug_abbrev,0,-30
bss,-32,0
.debug_ranges,0,-72
.debug_line,0,-73
.debug_str,0,-86
.debug_loc,0,-186
.debug_info,0,-373

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.strtab,0,68
.debug_ranges,0,40
.symtab,0,32
text,16,16
.debug_line,0,10
.debug_frame,0,-4
.debug_info,0,-28
.debug_abbrev,0,-30
.debug_loc,0,-33
.debug_str,0,-51

[github-actions]

Size increase report for "esp32-example-build" from b5eade0

File	Section	File	VM
chip-all-clusters-app.elf	.dram0.bss	0	-24

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.strtab,0,68
.xt.prop._ZN4chip29GlobalEncryptedMessageCounter10SetCounterEj,0,40
.symtab,0,16
.xt.prop._ZN4chip9Transport15PeerConnectionsILj16ELNS_4Time6SourceE0EE23FindPeerConnectionStateENS_8OptionalIyEEtPNS0_19PeerConnectionStateE,0,-12
.dram0.bss,-24,0
.debug_abbrev,0,-37
.xt.lit._ZN4chip9Transport15PeerConnectionsILj16ELNS_4Time6SourceE0EE23FindPeerConnectionStateENS_8OptionalIyEEtPNS0_19PeerConnectionStateE,0,-48
.debug_ranges,0,-56
.debug_str,0,-84
.debug_line,0,-172
.debug_info,0,-380
.debug_loc,0,-427

[github-actions]

Size increase report for "gn_qpg6100-example-build" from b5eade0

File	Section	File	VM
chip-qpg6100-lighting-example.out	.heap	0	24
chip-qpg6100-lighting-example.out	.bss	0	-24
chip-qpg6100-lighting-example.out	.text	-24	-24

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.strtab,0,68
.symtab,0,32
.heap,24,0
[Unmapped],0,24
.debug_frame,0,-4
.bss,-24,0
.text,-24,-24
.debug_abbrev,0,-30
.debug_ranges,0,-64
.debug_line,0,-73
.debug_str,0,-84
.debug_loc,0,-247
.debug_info,0,-374

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

[woody-apple]

@saurabhst @msandstedt @Damian-Nordic @andy31415 ?

[mrjerryjohns]

Nice minor cleanup!