[K32W] Save PDM to external flash on the DK6 board #7307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
saurabhst
approved these changes
Jun 2, 2021
woody-apple
requested changes
Jun 2, 2021
Done. |
jmartinez-silabs
approved these changes
Jun 3, 2021
LuDuda
approved these changes
Jun 3, 2021
| @@ -328,5 +320,6 @@ SECTIONS | |||
| PROVIDE(Chip_LOWPOWER_ChipSoftwareReset = 0x03003fa1); | |||
|
|
|||
| __StackLimit = _vStackTop - STACK_SIZE; | |||
| ASSERT(__StackLimit >= _end_boot_resume_stack, "Possible stack corruption with data/bss/boot_stack") | |||
| /* ASSERT(__StackLimit >= _end_boot_resume_stack, "Possible stack corruption with data/bss/boot_stack") */ | |||
There was a problem hiding this comment.
thanks, @LuDuda . I refactored this code a little.
doru91
force-pushed
the
feature/PDM_move
branch
2 times, most recently
from
d1dcb71 to
b91362d
Compare
This will free up 32.5K of internal flash space. Signed-off-by: Doru Gucea <[email protected]>
Signed-off-by: Doru Gucea <[email protected]>
woody-apple
approved these changes
Jun 7, 2021
Damian-Nordic
pushed a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 9, 2021
* [K32W] Save PDM to external flash on the DK6 board This will free up 32.5K of internal flash space. Signed-off-by: Doru Gucea <[email protected]> * Restyled by whitespace * Restyled by clang-format * Restyled by gn Signed-off-by: Doru Gucea <[email protected]> Co-authored-by: Restyled.io <[email protected]>
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* [K32W] Save PDM to external flash on the DK6 board This will free up 32.5K of internal flash space. Signed-off-by: Doru Gucea <[email protected]> * Restyled by whitespace * Restyled by clang-format * Restyled by gn Signed-off-by: Doru Gucea <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed?
Decrease the usage of the internal flash space (640K).
Change overview
Move Persistent Data Manager (PDM) from the internal flash to the external flash available on the DK6 development board.
Basically, we saved 32.5K of internal flash.
Testing
Created a large application (almost 640K) and run it ok. Before, it was impossible to run it because only PDM required 32.5K of the internal flash.