-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qr-code] Align QR Code format with the spec #7272
Merged
woody-apple
merged 5 commits into
project-chip:master
from
Damian-Nordic:update-setup-payload
Jun 7, 2021
Merged
[qr-code] Align QR Code format with the spec #7272
woody-apple
merged 5 commits into
project-chip:master
from
Damian-Nordic:update-setup-payload
Jun 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
android
controller
darwin
documentation
Improvements or additions to documentation
examples
setup payload
labels
Jun 1, 2021
Damian-Nordic
force-pushed
the
update-setup-payload
branch
from
June 1, 2021 14:48
d50a3fb
to
9932c41
Compare
pullapprove
bot
requested review from
andy31415,
bhaskar-apple,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jepenven-silabs,
LuDuda,
msandstedt,
sagar-apple and
vidhis88
June 1, 2021 15:14
Damian-Nordic
force-pushed
the
update-setup-payload
branch
from
June 1, 2021 15:30
9932c41
to
3e33a32
Compare
msandstedt
approved these changes
Jun 1, 2021
Damian-Nordic
force-pushed
the
update-setup-payload
branch
from
June 2, 2021 10:23
3e33a32
to
fc71c26
Compare
Damian-Nordic
force-pushed
the
update-setup-payload
branch
from
June 2, 2021 10:42
fc71c26
to
522c54d
Compare
andy31415
approved these changes
Jun 2, 2021
bzbarsky-apple
approved these changes
Jun 3, 2021
shana-apple
reviewed
Jun 3, 2021
Damian-Nordic
force-pushed
the
update-setup-payload
branch
from
June 3, 2021 15:56
2aa119b
to
b4322e4
Compare
Size increase report for "gn_qpg6100-example-build" from 575f99d
Full report output
|
Size increase report for "nrfconnect-example-build" from 575f99d
Full report output
|
Size increase report for "esp32-example-build" from 575f99d
Full report output
|
LuDuda
approved these changes
Jun 3, 2021
/rebase |
1. Replace boolean requiresCustomFlow with 2-bit field with the following meaning: 0 - device automatically enters paring mode upon power-up 1 - device needs user interaction to enter pairing mode 2 - device uses a vendor-specific flow that should be retrieved from the distributed ledger. 2. Replace CH: prefix with MT:
Co-authored-by: Boris Zbarsky <[email protected]>
Damian-Nordic
force-pushed
the
update-setup-payload
branch
from
June 7, 2021 06:33
b4322e4
to
d24997c
Compare
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* [qr-code] Align QR Code format with the spec 1. Replace boolean requiresCustomFlow with 2-bit field with the following meaning: 0 - device automatically enters paring mode upon power-up 1 - device needs user interaction to enter pairing mode 2 - device uses a vendor-specific flow that should be retrieved from the distributed ledger. 2. Replace CH: prefix with MT: * Restyled by clang-format * Update src/setup_payload/QRCodeSetupPayloadParser.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Restyled by clang-format * Fixes after rebase Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
android
controller
darwin
documentation
Improvements or additions to documentation
examples
review - approved
setup payload
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
QR Code format is no longer aligned with the spec after recent changes.
Change overview
the following meaning:
0 - device automatically enters paring mode upon power-up
1 - device needs user interaction to enter pairing mode
2 - device uses a vendor-specific flow that should be
retrieved from the distributed ledger.
Testing
setup-payload parse-qr
command.