Controller: use generated opcred cluster #7263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the clusters were not accessible to the controller so
the opcred clusters were copied in. Now they are accessible so we
should use the generated files.
Test: connected to lighting-app on linux using chip-device-ctrl
saw connection with successful passing of opcreds.
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
jmartinez-silabs
approved these changes
May 31, 2021
pan-apple
approved these changes
Jun 1, 2021
jelderton
approved these changes
Jun 1, 2021
bzbarsky-apple
approved these changes
Jun 1, 2021
pullapprove
bot
added
review - approved
and removed
review - pending
technical review - DONE
labels
|
@cecille This probably needs to be rebased to tip to fix darwin CI. |
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Previously, the clusters were not accessible to the controller so
the opcred clusters were copied in. Now they are accessible so we
should use the generated files.
Test: connected to lighting-app on linux using chip-device-ctrl
saw connection with successful passing of opcreds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, the clusters were not accessible to the controller so
the opcred clusters were copied in. Now they are accessible so we
should use the generated files.
Change overview
Removes the opcreds cluster files added to the controller and replaces with the files in the gen directory.
Testing
connected to lighting-app on linux using chip-device-ctrl. Saw connection with successful passing of opcreds.