Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger CASE session setup #7237

Merged
merged 1 commit into from
May 31, 2021

Conversation

pan-apple
Copy link
Contributor

Problem

The repeated CASE Session setup causes device to run out of heap.

Change overview

The CASEServer code needs to detect duplicate sessions and free the older one, before setting up the new session. Currently, the repeated sessions are causing the device to hold on to the older session, while a new one gets setup.

This PR removes the trigger to setup CASE session, as it's not needed for TE3.

Reference: #7235

Testing

Tested using Python controller and iOS CHIPTool app.

@todo
Copy link

todo bot commented May 28, 2021

- Enable CASE Session setup before message is sent to a fully provisioned device

// TODO - Enable CASE Session setup before message is sent to a fully provisioned device
// if (IsProvisioningComplete())
// {
// err = EstablishCASESession();
// SuccessOrExit(err);
// }
exit:


This comment was generated by todo based on a TODO comment in 7243b18 in #7237. cc @pan-apple.

@andy31415 andy31415 merged commit cbbcd19 into project-chip:master May 31, 2021
@pan-apple pan-apple deleted the case-trigger branch June 1, 2021 18:35
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants