Fix crash caused by uninitialized variable #7230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damian-Nordic
approved these changes
May 28, 2021
bzbarsky-apple
approved these changes
May 28, 2021
saurabhst
approved these changes
May 31, 2021
andy31415
reviewed
May 31, 2021
andy31415
approved these changes
May 31, 2021
|
@bluebin14 - could you try making a change and re-updating this PR? Restyler seems stuck. maybe the change could be to add more nullptr initializations as in my comment. |
pullapprove
bot
requested review from
chrisdecenzo,
jelderton and
jmartinez-silabs
jmartinez-silabs
approved these changes
May 31, 2021
jelderton
approved these changes
Jun 1, 2021
|
@bluebin14 Needs rebase to tip to fix the Darwin failure... |
|
/rebase |
woody-apple
force-pushed
the
shutdown-crash-fix
branch
from
6dff033 to
dcbf486
Compare
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Fix crash caused by uninitialized variable * Initialize remaining member variables that are pointers * changes by restyler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed?
Change overview
This PR fixes crash caused by uninitialized member variable. The crash happened in DeviceController::Shutdown().
Testing
How was this tested? (at least one bullet point required)
Result without the fix: crash with segmentation fault on the following place in src/controller/CHIPDeviceController .cpp DeviceController::Shutdown()
chip::Platform::Delete(mDefaultIMDelegate);
Result with the fix: application tears down correctly and exits.