Extend build flags for ip commissioning on linux[TE3] #7214
Conversation
Lets the linux builds be built with IP commissioning support. Adds
the on-network flag to the QR code on the app main.
Test: lighting-app on linux - comes up in commissioning mode,
chip-device-ctrl connect -qr "[qr code]" can find and
commission the device.
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
| @@ -36,6 +38,10 @@ source_set("app-main") { | |||
| if (chip_enable_pw_rpc) { | |||
| defines += [ "PW_RPC_ENABLED" ] | |||
| } | |||
| if (chip_ip_commissioning) { | |||
| # BLE and on-network. Code defaults to BLE if this is not set. | |||
| defines += [ "CONFIG_RENDEZVOUS_MODE=6" ] | |||
There was a problem hiding this comment.
It is not mandatory for commissioners to use this bitmask. In fact, since this bitmask is absent from numerical pairing code, it is merely a hint.
Overall, the commissioner examples should just "look everywhere they can" for devices to be commissioned. The onboarding payload does enable filtering down with additional knowledge to reduce possibility of discriminator collision.
Is there an issue tracking this?
There was a problem hiding this comment.
From discussion offline - the codes are not optional in the QR code. This flag doesn't control anything on-device. Right now, the commissioner example code (chip-device-ctrl) has a direct IP and a direct BLE connection, but also supports connecting from the QR code, which pulls the setup pin, discriminator and rendezvous flags. The QR code pairing example will only check the flags in the QR code, as these are mandatory. An implementation of a manual pairing in the example controller would include all, but has not been written yet.
yunhanw-google
changed the title
|
@bzbarsky-apple @franck-apple this is also needed for IP commissioning in TE3. |
Lets the linux builds be built with IP commissioning support. Adds
the on-network flag to the QR code on the app main.
Test: lighting-app on linux - comes up in commissioning mode,
chip-device-ctrl connect -qr "[qr code]" can find and
commission the device.
Lets the linux builds be built with IP commissioning support. Adds
the on-network flag to the QR code on the app main.
Test: lighting-app on linux - comes up in commissioning mode,
chip-device-ctrl connect -qr "[qr code]" can find and
commission the device.
Problem
Not all the device paths support on-network commissioning
Change overview
Adds gn build flag to set defines for IP commissioning
Testing
Tested using lighting-app built for linux with chip_ip_commissioning flag set. Connected to lighting app using chip-device-ctrl, was able to discover and commission automatically using connect -qr "[qr code]"