Fix resolve on BLE from ip network commissioning. #7213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IP network provisioning was incorrectly early-returning from the resolve callback and not sending data through to the python stack for BLE.
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
bzbarsky-apple
approved these changes
May 28, 2021
Damian-Nordic
approved these changes
May 28, 2021
saurabhst
approved these changes
May 28, 2021
|
@cecille Thank you for the quick fix! |
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
IP network provisioning was incorrectly early-returning from the resolve callback and not sending data through to the python stack for BLE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IP network provisioning was incorrectly early-returning from the
resolve callback and not sending data through to the python stack
for BLE.
Problem
IP network commissioning broke the resolve portion of the BLE connection
Change overview
Fixes the OnNodeIdResolved function to remove early return that bypassed the python delegate.
Testing
Set up M5 with no network credentials. Connected via chip-device-ctrl using BLE
connect -qr "[qrcode]"
zcl NetworkCommissioning AddWiFiNetwork [nodeid] 0 0 ssid=str:[ssid] credentials=str:[pass] breadcrumb=0 timeoutMs=1000
zcl NetworkCommissioning EnableNetwork [nodeid] 0 0 networkID=str:[ssid] breadcrumb=0 timeoutMs=1000
resolve 0 [nodeid]
Last resolve used to fail, now it passes.