Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative link path #7202

Merged
merged 1 commit into from
May 27, 2021
Merged

Fix relative link path #7202

merged 1 commit into from
May 27, 2021

Conversation

andy31415
Copy link
Contributor

Problem

CI on commits is full-red because we now check link paths.

Change overview

Add an extra '../' to a reference from docs/Readme.md into src

Testing

Text file modification only, checked that path looks ok. Final test will be CI.

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label May 27, 2021
@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label May 27, 2021
@andy31415
Copy link
Contributor Author

Hotfix because our CI on commited changes is red.

@andy31415 andy31415 merged commit 7a172f3 into project-chip:master May 27, 2021
andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request May 27, 2021
This reverts commit 7a172f3.
Apparently link checker is not fully working and this broke doxygen.
andy31415 added a commit that referenced this pull request May 27, 2021
* Linux platform example app includes SHELL unconditionally.

Force defines and linkages as such, otherwise compilation with GN
without 'use shell' does not work.

TODO as followup: if shell is really optional, build it as such in linux
as well.

* remove the enable shell arg alltogether - it does not work because includes are already there

* Revert "Fix relative path for the markdown link (#7202)"

This reverts commit 7a172f3.
Apparently link checker is not fully working and this broke doxygen.
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Will not wait for long CI push for a md change. Wnat to move master commit list back to green.
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…hip#7205)

* Linux platform example app includes SHELL unconditionally.

Force defines and linkages as such, otherwise compilation with GN
without 'use shell' does not work.

TODO as followup: if shell is really optional, build it as such in linux
as well.

* remove the enable shell arg alltogether - it does not work because includes are already there

* Revert "Fix relative path for the markdown link (project-chip#7202)"

This reverts commit 7a172f3.
Apparently link checker is not fully working and this broke doxygen.
@andy31415 andy31415 deleted the fix_links branch October 28, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hotfix urgent fix needed, can bypass review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant