-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CHIPConnection to CHIPUdpExchange #711
Conversation
Reasoning is that UDP is connectionless, so we use "exchange" to denote exchanging messages. Future CHIPConnection will actually handle connection protocols (tcp, ble).
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
+ Coverage 53.93% 59.66% +5.72%
==========================================
Files 135 130 -5
Lines 13654 12650 -1004
==========================================
+ Hits 7364 7547 +183
+ Misses 6290 5103 -1187
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems innocuous if it supports a larger, later goal.
Nit: the PR title doesn't need to specify the |
LGTM! @andy31415, how do you feel about filing an issue for this. Just so we never forget to come back and clean/reorg ChipUdpExchange. Maybe when Message Layer comes in this becomes obsolete ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought per discussion we'd do this when the CHIPConnection + Managers above are in place, that would replace this?
Let's do this as a part of: #157
I am trying to make deltas smaller. This rename can for sure be part of a WML move, however it seems that renaming is very self-contained so I figured we can approve separately. Please LMK what to do with this - there are a few approvals here, however I would only like to submit when there are no outstanding comments. |
Can we do this as part of the other discussion draft PR? I think this helps bring context to that change. |
I created a wholesale PR with the entire message layer in #756 It is huge and I am still unclear what was agreed upon regardig the messaging layer. I get conflicting information. What would be the best way forward? |
Closing as we will move these into the transpor layer instead. I will rename them in that context. |
* Update Test_TC_ACL_2_1.yaml Fixes Issues #711[CHIP-Specifications/chip-certification-tool#711] * Updating auto gen files * undo formatting changes
* Update Test_TC_ACL_2_1.yaml Fixes Issues project-chip#711[CHIP-Specifications/chip-certification-tool#711] * Updating auto gen files * undo formatting changes
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
…e + Nest Hub Merge in WMN_TOOLS/matter from feature/unifymatterbridge-googlehome to silabs Squashed commit of the following: commit bcadf935457d1e8b5d7a5b9d133a03e24a7b9ef6 Author: Jonas Roum-Møller <[email protected]> Date: Mon Apr 24 13:47:43 2023 +0200 Added steps for configuring Google Home + Nest Hub
Reasoning is that UDP is connectionless, so we use "exchange" to denote
exchanging messages.
Future CHIPConnection will actually handle connection protocols (tcp,
ble).
Problem
Short version is "UDP is connectionless".
We are considering that several transports including UDP, TCP, BLE, ... are ok for exchanging requests and replies between devices, however a "connection" has additional meaning.
Summary of Changes
Renames existing CHIPConnection to ChipUdpExchange.
Weave port of CHIPConnection does the connection bit (TCP and BLE) and will not replace this class. The weave message layer does support UDP however that will only come in once we have the exchange bits ported. Only at that time, an code merge & update can be feasable.
working towards #157 and #158.