-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup CASE state machine for error handling and logging #7103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhst
approved these changes
May 25, 2021
(#6668): Some exchange has leak, shutting down ExchangeManager will cause a assert fail.connectedhomeip/src/controller/CHIPDeviceController.cpp Lines 311 to 314 in 7b3582b
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248 and
jepenven-silabs
May 26, 2021 01:48
jelderton
approved these changes
May 28, 2021
bzbarsky-apple
approved these changes
Jun 1, 2021
rebased |
Size increase report for "nrfconnect-example-build" from b40ed7a
Full report output
|
Size increase report for "esp32-example-build" from b40ed7a
Full report output
|
Size increase report for "gn_qpg6100-example-build" from b40ed7a
Full report output
|
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…ip#7103) * Cleanup CASE state machine for error handling and logging * cleanup * defer exchange mgr shutdown to a separate PR * add documentation to the function * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CASE session holds on to exchange context even after Sigma handshake is complete. Also, the error handling and logging could be improved.
Change overview
Close exchange on Sigma handshake completion. Update logging to use
SecureChannel
tag. Cleanup error handling.Testing
TestCASESession
unit tests.Tested with Python controller app, and iOS CHIPTool app for pairing.
Fixes #7070