Moving OpenSSL Package Config into Common BUILD #7018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bhaskar-apple,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
Damian-Nordic
approved these changes
May 21, 2021
emargolis
force-pushed
the
feature/emargolis/move-openssl-pkg-config
branch
from
36a59cb to
ab1cd9e
Compare
woody-apple
requested changes
May 21, 2021
updated |
andy31415
approved these changes
May 25, 2021
msandstedt
approved these changes
May 25, 2021
|
"Manually tested by generating, converting and verifying various CHIP certificate" could we add an automated test here? Or does one already exist? |
|
@woody-apple - summary was updated according to the template |
Opened #7104 to follow up. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
woody-apple
approved these changes
Jun 3, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently pkg_config for OpenSSL is run twice by src/crypto/BUILD.gn and src/tools/chip-cert/BUILD.gn.
Change overview
src/tools/chip-cert/BUILD.gn is using OpenSSL package generated by src/crypto/BUILD.gn
Testing
Manually tested by generating, converting and verifying various CHIP certificates.
Ticket #6796