Enable arc for chip-device-ctrl #6992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
jmartinez-silabs
approved these changes
May 20, 2021
|
ARC did find some issues with the Darwin build. Can you push a fix for those build error? |
Damian-Nordic
approved these changes
May 20, 2021
vivien-apple
force-pushed
the
Darwin_EnableARC
branch
from
516234e to
cf2247e
Compare
woody-apple
requested changes
May 20, 2021
There was a problem hiding this comment.
Per the updated template, can you update the PR here?
#### Problem
What is being fixed? Examples:
* Fix crash on startup
* Fixes #12345 12345 Frobnozzle is leaky (exactly like that, so GitHub will auto-close the issue).
#### Change overview
What's in this PR
#### Testing
How was this tested? (at least one bullet point required)
• If unit tests were added, how do they cover this issue?
• If unit tests existed, how were they fixed/modified to prevent this in future?
• If integration tests were added, how do they verify this change?
• If manually tested, what platforms controller and device platforms were manually tested, and how?
• If no testing is required, why not?
cf2247e to
2dcc1b5
Compare
vivien-apple
force-pushed
the
Darwin_EnableARC
branch
from
2dcc1b5 to
325c18d
Compare
andy31415
approved these changes
May 25, 2021
|
@woody-apple summary was updated according to the template |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
mspang
approved these changes
Jun 2, 2021
woody-apple
approved these changes
Jun 3, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ARCis not enabled forsrc/platform/Darwinwhich results into leaks.Change overview
-fobjc-arcinsrc/platform/BUILD.gnwhenchip_device_layeris set todarwin.-fobjc-arcinsrc/platform/python/BUILD.gnsince it contains custom Objc++ files.src/platform/Darwin/*.mmfiles that needs it.src/platform/python/chip/darwin/*.mmfiles.Testing
This is not especially easy to write tests for ARC. So I did manual testing involving pairing over BLE in order to validate the underlying BLE stack using
chip-toolon Mac andiOS ChipTool.