Remove some of generated binaries as artifacts. #6976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github enforces a artifact storage quotas, we only require artifacts for some size deltas and there is little incremental benefit to adding more applications for similar platforms. Tried to only keep one example application as an artifact.
pullapprove
bot
requested review from
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt,
mspang and
woody-apple
woody-apple
approved these changes
May 19, 2021
saurabhst
approved these changes
May 19, 2021
jmartinez-silabs
approved these changes
May 19, 2021
While this may be largely true today, we should also be able to produce builds of the examples at each milestone (e.g. for interop testing purposes). For that use case, this is a step backwards..
|
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Github enforces a artifact storage quotas, we only require artifacts for some size deltas and there is little incremental benefit to adding more applications for similar platforms. Tried to only keep one example application as an artifact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Github enforces a artifact storage quotas, we only require artifacts for
some size deltas and there is little incremental benefit to adding more
applications for similar platforms.
Tried to only keep one example application as an artifact.
Summary of Changes
Remove some of the artifact uploads.
Testing:
github workflow, not tested however expect github execution to have information about what was uploaded and detect success/failure.