Update the zap template used for chip-tool to not forced the first le… #6930
Conversation
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
| @@ -186,9 +186,9 @@ public: | |||
| { | |||
| {{#chip_server_cluster_command_arguments}} | |||
| {{#if (isString type)}} | |||
| AddArgument("{{asCamelCased label}}", &m{{asCamelCased label false}}); | |||
| AddArgument("{{asCamelCased label false}}", &m{{asCamelCased label false}}); | |||
There was a problem hiding this comment.
For future PRs we may want to look into API readability: the false argument is not obvious in purpose. Maybe something like startUpperCamelCase and startLowerCamelCase methods would be more readable, although I find those namings awkward as well. Can these be chained? like camelCase label | uppercaseFirstLetter
There was a problem hiding this comment.
Per the updated template, can you update the PR here?
#### Problem
What is being fixed? Examples:
* Fix crash on startup
* Fixes #12345 12345 Frobnozzle is leaky (exactly like that, so GitHub will auto-close the issue).
#### Change overview
What's in this PR
#### Testing
How was this tested? (at least one bullet point required)
• If unit tests were added, how do they cover this issue?
• If unit tests existed, how were they fixed/modified to prevent this in future?
• If integration tests were added, how do they verify this change?
• If manually tested, what platforms controller and device platforms were manually tested, and how?
• If no testing is required, why not?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This stale pull request has been automatically closed. Thank you for your contributions. |
|
@vivien-apple This is still relevant, right? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
/rebase |
|
/rebase |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
…tter of arguments to be lower cased
vivien-apple
force-pushed
the
ChipTool_ArgumentLowercase
branch
from
da739ac to
2f18ca6
Compare
|
@woody-apple I have finally updated the template... |
project-chip#6930) * Update the zap template used for chip-tool to not forced the first letter of arguments to be lower cased * Update gen/ folders
…tter of arguments to be lower cased
Problem
Followup to #6873 where arguments such as
CSRNonceends up ascSRNonce.Summary of Changes
Testing
./scripts/tests/test_suites.shjust to validate that argument parsing is not broken