Added placeholder files for PCC default implementation #6926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
msandstedt
approved these changes
May 19, 2021
|
Please add a section of 'how did you test this' on the PR summary. |
woody-apple
requested changes
May 20, 2021
There was a problem hiding this comment.
Per the updated template, can you update the PR here?
#### Problem
What is being fixed? Examples:
* Fix crash on startup
* Fixes #12345 12345 Frobnozzle is leaky (exactly like that, so GitHub will auto-close the issue).
#### Change overview
What's in this PR
#### Testing
How was this tested? (at least one bullet point required)
• If unit tests were added, how do they cover this issue?
• If unit tests existed, how were they fixed/modified to prevent this in future?
• If integration tests were added, how do they verify this change?
• If manually tested, what platforms controller and device platforms were manually tested, and how?
• If no testing is required, why not?
bzbarsky-apple
approved these changes
May 21, 2021
woody-apple
approved these changes
May 21, 2021
tlykkeberg-grundfos
force-pushed
the
feature/add-pcc-cluster-implementation
branch
from
878691e to
60c7df9
Compare
|
Can one of you please review this PR, we are missing one approval? @saurabhst @jepenven-silabs @andy31415 |
saurabhst
approved these changes
May 27, 2021
andy31415
approved these changes
May 27, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…6926) * Added placeholder files for PCC default implementation * Restyled by clang-format * Corrected the commit to the in line with the master on the CHIP repo Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
What's in this PR
src/app/clusters/pump-control-and-configuration-server/pump-control-and-configuration-server.cppsrc/app/clusters/pump-control-and-configuration-client/pump-control-and-configuration-client.cppsrc/app/zap_cluster_list.pyTesting
How was this tested? (at least one bullet point required)
examples/pump-app/cc13x2x7_26x2x7and theexamples/pump-controller-app/cc13x2x7_26x2x7which both contains the PCC cluster and verified that the code did compile and link.