Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add building of TV example to gn_build.sh #6903

Conversation

lazarkov
Copy link
Contributor

Problem

TV example app is not built using gn_build.sh script

Summary of Changes

  • Updated the ./BUILD.gn to support building of tv-example-app

Test

  • Tested locally using chip-tool client and tv-server
  • Used the ./gn_build.sh to verify the building is successful

Copy link
Contributor

@yunhanw-google yunhanw-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you

Problem
TV example app is not built using gn_build.sh script

Summary of Changes
- Updated the ./BUILD.gn to support building of tv-example-app

Test
Used the ./gn_build.sh to verify the building is successful
@woody-apple
Copy link
Contributor

@woody-apple
Copy link
Contributor

@woody-apple woody-apple merged commit 7fe8c92 into project-chip:master May 18, 2021
@lazarkov lazarkov deleted the feature/add-tv-example-app-to-gn-build branch December 23, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants