-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CRMP for command responses. #6847
Enable CRMP for command responses. #6847
Conversation
This used to be enabled but was disabled for some reaason in project-chip#5945. There's no obvious reason to disable this.
Size increase report for "nrfconnect-example-build" from 8a51de2
Full report output
|
Size increase report for "esp32-example-build" from 8a51de2
Full report output
|
We met some crash due to crmp during enableing im, not sure if @yufengwangca has fixed it. It is ok to enable it if the previous race condition has been fixed. |
Due to enabling for CommandSender or CommandHandler? In the past I saw some isses on the sender side, but not on the handler side. Fwiw, I ran the Darwin CI ~15 times with this change; it passed every time. |
This used to be enabled but was disabled for some reaason in #5945. There's no obvious reason to disable this.
Problem
CRMP is disabled on the server side (in CommandHandler).
Summary of Changes
Enable it.