Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CRMP for command responses. #6847

Merged
merged 1 commit into from
May 17, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented May 15, 2021

This used to be enabled but was disabled for some reaason in #5945. There's no obvious reason to disable this.

Problem

CRMP is disabled on the server side (in CommandHandler).

Summary of Changes

Enable it.

This used to be enabled but was disabled for some reaason in project-chip#5945.  There's no obvious reason to disable this.
@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 8a51de2

File Section File VM
chip-lock.elf device_handles 4 4
chip-lock.elf text -4 -4
chip-lighting.elf device_handles 4 4
chip-lighting.elf text -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_ranges,0,56
.debug_line,0,16
device_handles,4,4
text,-4,-4
.debug_info,0,-8

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_ranges,0,56
.debug_line,0,13
device_handles,4,4
.debug_loc,0,-4
text,-4,-4
.debug_info,0,-9


@github-actions
Copy link

Size increase report for "esp32-example-build" from 8a51de2

File Section File VM
chip-all-clusters-app.elf .flash.text -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_ranges,0,56
.debug_line,0,8
.debug_loc,0,-4
.flash.text,-4,-4
.debug_info,0,-8

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


@erjiaqing
Copy link
Contributor

We met some crash due to crmp during enableing im, not sure if @yufengwangca has fixed it.

It is ok to enable it if the previous race condition has been fixed.

@bzbarsky-apple
Copy link
Contributor Author

We met some crash due to crmp during enableing im

Due to enabling for CommandSender or CommandHandler? In the past I saw some isses on the sender side, but not on the handler side.

Fwiw, I ran the Darwin CI ~15 times with this change; it passed every time.

@andy31415 andy31415 merged commit ca8c40a into project-chip:master May 17, 2021
@bzbarsky-apple bzbarsky-apple deleted the enable-crmp-server branch May 19, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants