[K32W] Add functionality to run lock-app and lighting-app without OM15082 Expansion board #6813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OM15082 Expansion board LED D2 and LED D3 functionality are redirected to LED DS2 and LED DS3 on the DK6 board if OM15082 is not attached. Also the factory reset action can be done by long pressing the USERINTERFACE button on DK6 board. If the OM15082 Expansion Board is attached to the DK6 board, then chip_with_OM15082 should be set to 1 in the gn build instruction. By default chip_with_OM15082 is zero. Signed-off-by: PetruSicoe <[email protected]>
PetruSicoe
changed the title
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
woody-apple
approved these changes
May 14, 2021
andy31415
reviewed
May 14, 2021
| @@ -241,6 +241,12 @@ void AppTask::ButtonEventHandler(uint8_t pin_no, uint8_t button_action) | |||
| else if (pin_no == BLE_BUTTON) | |||
| { | |||
| button_event.Handler = BleHandler; | |||
| #if !(defined OM15082) | |||
There was a problem hiding this comment.
should this not be using defined(OM15082) instead of (defined OM15082) ? I find the bracketing a bit odd ... gcc defined docs seem to only describe the brackets after the keyword.
Is this a style that is valid?
There was a problem hiding this comment.
I just tested it and it does work ... but feels unusual. Are there docs on why it works?
There was a problem hiding this comment.
Hey @andy31415, that syntax is basically the one described from GCC standard defined OM15082 wrapped around parenthesis. Check out the reference link under examples and also the godbolt that I've baked.
andy31415
approved these changes
May 14, 2021
msandstedt
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OM15082 Expansion board
LED D2 and LED D3 functionality are redirected to LED DS2 and LED DS3
on the DK6 board if OM15082 is not attached.
Also the factory reset action can be done by long pressing the
USERINTERFACE button on DK6 board.
If the OM15082 Expansion Board is attached to the DK6 board, then
chip_with_OM15082 should be set to 1 in the gn build instruction.
By default chip_with_OM15082 is zero.
Signed-off-by: PetruSicoe [email protected]