-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add darwin test for general diagnostics cluster, and fix incorrect reinterpret_cast that got added #6804
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:add-darwin-test-for-general-diagnostics
May 14, 2021
Merged
Add darwin test for general diagnostics cluster, and fix incorrect reinterpret_cast that got added #6804
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:add-darwin-test-for-general-diagnostics
May 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHAR_STRING not supported yet in structs.connectedhomeip/src/app/zap-templates/zcl/custom-types.xml Lines 64 to 68 in 8de069c
This comment was generated by todo based on a
|
bzbarsky-apple
force-pushed
the
add-darwin-test-for-general-diagnostics
branch
2 times, most recently
from
May 14, 2021 07:21
75fa695
to
65c68f9
Compare
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
May 14, 2021 07:25
andy31415
approved these changes
May 14, 2021
woody-apple
approved these changes
May 14, 2021
jmartinez-silabs
approved these changes
May 14, 2021
saurabhst
approved these changes
May 14, 2021
Some notes: 1) This cluster appears on endpoint 0 on all-clusters-app, so we have to add it to the list in src/darwin/Framework/CHIP/templates/helper.js. 2) CHAR_STRING is not supported in structs yet. Hence switch NetworkInterfaceType to using OCTET_STRING. 3) Remove the incorrect reinterpret_cast that was added to src/app/zap-templates/templates/app/attribute-size-src.zapt.
bzbarsky-apple
force-pushed
the
add-darwin-test-for-general-diagnostics
branch
from
May 14, 2021 22:49
65c68f9
to
bc6df36
Compare
Size increase report for "esp32-example-build" from f4b00be
Full report output
|
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 17, 2021
There was a merge conflict that was not detected by automatic merge between project-chip#6822 and project-chip#6804 that caused files removed by the former to be re-created by the latter. Those files should not exist.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 17, 2021
There was a merge conflict that was not detected by automatic merge between project-chip#6822 and project-chip#6804 that caused files removed by the former to be re-created by the latter. Those files should not exist.
woody-apple
pushed a commit
that referenced
this pull request
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
General diagnostics did not get added to our various chip-tools (darwin and example).
Summary of Changes
Add it to the tools, fix it to compile correctly and pass the tests.
Fixes #6801