[mdns] fix mDNS type length #6771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhst
approved these changes
May 13, 2021
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
mspang
wgtdkp
force-pushed
the
fix-mdns-type-length
branch
from
9b2c5ee to
dd0119c
Compare
andy31415
reviewed
May 13, 2021
| service.mName[kMdnsNameMaxSize] = 0; | ||
| strncpy(typeAndProtocol, type, sizeof(typeAndProtocol)); |
There was a problem hiding this comment.
why do we need a separate copy?
The original code is suspect because it uses a local variable probably due to const-correctness. However getting the protocol from type seems totally doable in const char *.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
typeparameter inMdnsAvahi::HandleBrowseincludes the protocol (_tcpor_udp) as suffixbut the
MdnsService::mTypefields includes only the service type. The Linux avahi implementationresults in failures in browse and resolve handler.
Summary of Changes
This PR uses a local buffer for copying the
typeargument and parsing it into true service typeand protocol fields.
Fixes #6773