[shell] move common shell commands to core library

[gjc13]

Problem

We'd like to have a user-friendly CLI in the devices for developing and testing as we have in OpenThread.

Summary of Changes

This is the first PR of the effort to add shell as an optional component for all devices.
Main changes include:

• Move wifi, ble and device config command to common library
• The wifi commands has been simplified with less modes.
  Platform-specific commands have been removed.
• The btp command is renamed to ble with all the not-implemented commands removed.
• The device config command is renamed to config with unused configs removed.
• Fix shell formatting on ESP32.

[todo]

Enable wifi network should be done by ConnectivityManager. (Or other platform neutral interfaces)

connectedhomeip/src/lib/shell/commands/CommandWiFi.cpp

Lines 26 to 36 in 043bb68

	// TODO: Enable wifi network should be done by ConnectivityManager. (Or other platform neutral interfaces)
	#if defined(CHIP_DEVICE_LAYER_TARGET)
	#define DEVICENETWORKPROVISIONING_HEADER <platform/CHIP_DEVICE_LAYER_TARGET/DeviceNetworkProvisioningDelegateImpl.h>
	#include DEVICENETWORKPROVISIONING_HEADER
	#endif
	using chip::DeviceLayer::ConnectivityManager;
	using chip::DeviceLayer::ConnectivityMgr;
	namespace chip {
	namespace Shell {

---

This comment was generated by todo based on a TODO comment in 043bb68 in #6765. cc @gjc13.

[andy31415]

Please rename code to NOT use names like helper/support/util/tools/core.

These names do not describe what the contents of the file generally is and end up being filled with unrelated parts of code as a result.

shell/shell_core.h stutters and if I remove the stutter I get shell/core.h which is unclear about what that is.

[andy31415]

Would also avoid 'common' in names.

[woody-apple]

/rebase

[gjc13]

@andy31415 PTAL

[Damian-Nordic]

Note that we had renamed shell/shell.h to shell/shell_core.h to fix filename collision with Zephyr-supplied shell/shell.h. Now that the file was renamed to Shell.h the issue is gone on Linux/mac, but may still appear on case-insensitive systems like Windows. Can we possibly rename it to something like Engine.h? @andy31415 would you approve such a name? :)

[gjc13]

@Damian-Nordic renamed.

[Damian-Nordic]

Thank you!

[github-actions]

Size increase report for "nrfconnect-example-build" from 8a51de2

File	Section	File	VM
chip-shell.elf	datas	-8	-8
chip-shell.elf	device_handles	-12	-12
chip-shell.elf	bss	0	-96
chip-shell.elf	rodata	-3240	-3240
chip-shell.elf	text	-3428	-3428

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,24430
.debug_line,0,4228
.debug_abbrev,0,4198
.shstrtab,0,-3
datas,-8,-8
device_handles,-12,-12
.debug_aranges,0,-56
bss,-96,0
.debug_frame,0,-416
.debug_ranges,0,-520
.debug_str,0,-682
.symtab,0,-2496
rodata,-3240,-3240
text,-3428,-3428
.strtab,0,-3545
.debug_loc,0,-4438

[andy31415]

Note that we had renamed shell/shell.h to shell/shell_core.h to fix filename collision with Zephyr-supplied shell/shell.h. Now that the file was renamed to Shell.h the issue is gone on Linux/mac, but may still appear on case-insensitive systems like Windows. Can we possibly rename it to something like Engine.h? @andy31415 would you approve such a name? :)

Sure. Also my request to avoid odd names is not a ban, just trying hard. If there is a naming clash then that seems to warrant a name change. Would not block PR over this for sure.