-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial version of the General Diagnostics Cluster #6690
Add initial version of the General Diagnostics Cluster #6690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is mostly generated code - PR is too large to review
@yufengwangca Sorry, conflict here :( |
/rebase |
Size increase report for "esp32-example-build" from 8d203d7
Full report output
|
Size increase report for "nrfconnect-example-build" from 8d203d7
Full report output
|
…ct-chip#6690)" This reverts commit c7b49a9.
@@ -86,7 +86,7 @@ uint16_t emberAfCopyList(ClusterId clusterId, EmberAfAttributeMetadata * am, boo | |||
{{chipType}} * entry = reinterpret_cast<{{chipType}} *>(write ? src : dest); | |||
{{#chip_attribute_list_entryTypes}} | |||
{{#if (isString type)}} | |||
chip::ByteSpan * {{name}}Span = &entry->{{name}}; // {{type}} | |||
chip::ByteSpan * {{name}}Span = reinterpret_cast<chip::ByteSpan *>(&entry->{{name}}); // {{type}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we reinterpret-cast here? why is the entry name not of the correct type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what #6801 was about.
Problem
The General Diagnostics Cluster, along with other diagnostics clusters, provide a means to acquire standardized diagnostics metrics that MAY be used by a Node to assist a user or Administrative Node in diagnosing potential problems.
The specification of General Diagnostics Cluster:
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/service_device_management/DiagnosticsGeneral.adoc
Summary of Changes
Add initial version of the General Diagnostics Cluster