Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial version of the General Diagnostics Cluster #6690

Merged
merged 3 commits into from
May 13, 2021
Merged

Add initial version of the General Diagnostics Cluster #6690

merged 3 commits into from
May 13, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

The General Diagnostics Cluster, along with other diagnostics clusters, provide a means to acquire standardized diagnostics metrics that MAY be used by a Node to assist a user or Administrative Node in diagnosing potential problems.

The specification of General Diagnostics Cluster:
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/service_device_management/DiagnosticsGeneral.adoc

Summary of Changes

Add initial version of the General Diagnostics Cluster

Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is mostly generated code - PR is too large to review

@woody-apple
Copy link
Contributor

@yufengwangca Sorry, conflict here :(

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

Size increase report for "esp32-example-build" from 8d203d7

File Section File VM
chip-all-clusters-app.elf .flash.rodata 312 312
chip-all-clusters-app.elf .flash.text 276 276
chip-all-clusters-app.elf .dram0.bss 0 256
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_line,0,627
.debug_info,0,480
.flash.rodata,312,312
.flash.text,276,276
.dram0.bss,256,0
.debug_str,0,222
.debug_loc,0,218
.strtab,0,50
.debug_frame,0,24
.debug_ranges,0,24
.debug_abbrev,0,18
.symtab,0,16
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,-1
.shstrtab,0,-2
[Unmapped],0,-312


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 8d203d7

File Section File VM
chip-lighting.elf text 604 604
chip-lighting.elf rodata 432 436
chip-lighting.elf bss 0 256
chip-lighting.elf device_handles 4 4
chip-lock.elf text 556 556
chip-lock.elf rodata 432 436
chip-lock.elf bss 0 256
chip-lock.elf device_handles 4 4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,10606
.debug_loc,0,2711
.debug_line,0,2484
.debug_abbrev,0,1394
text,604,604
.debug_str,0,581
rodata,436,432
.debug_ranges,0,416
bss,256,0
.symtab,0,208
.strtab,0,206
.debug_frame,0,168
.debug_aranges,0,48
device_handles,4,4
.shstrtab,0,-2

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,10609
.debug_loc,0,2655
.debug_line,0,2481
.debug_abbrev,0,1394
.debug_str,0,581
text,556,556
rodata,436,432
.debug_ranges,0,416
bss,256,0
.symtab,0,224
.strtab,0,206
.debug_frame,0,168
.debug_aranges,0,48
device_handles,4,4
.shstrtab,0,-2


@woody-apple woody-apple merged commit c7b49a9 into project-chip:master May 13, 2021
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this pull request May 14, 2021
@@ -86,7 +86,7 @@ uint16_t emberAfCopyList(ClusterId clusterId, EmberAfAttributeMetadata * am, boo
{{chipType}} * entry = reinterpret_cast<{{chipType}} *>(write ? src : dest);
{{#chip_attribute_list_entryTypes}}
{{#if (isString type)}}
chip::ByteSpan * {{name}}Span = &entry->{{name}}; // {{type}}
chip::ByteSpan * {{name}}Span = reinterpret_cast<chip::ByteSpan *>(&entry->{{name}}); // {{type}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we reinterpret-cast here? why is the entry name not of the correct type?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what #6801 was about.

@yufengwangca yufengwangca deleted the pr/cluster/general_diagnostics branch May 14, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants