Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendezvous bypass mode #6681

Merged
merged 2 commits into from
May 12, 2021
Merged

Conversation

pan-apple
Copy link
Contributor

Problem

Rendezvous bypass mode is not working. It's failing in establishing the secure session.

Summary of Changes

Recent controller changes mixed using test secret with non-test pairing. This change makes sure that the test secret is used for establishing the secure session when bypass mode is being used.

Fixes #6578

Copy link
Contributor

@tcarmelveilleux tcarmelveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding handling of better error message for:

VerifyOrExit(peerAddress.GetTransportType() == Transport::Type::kUdp, err = CHIP_ERROR_INVALID_ARGUMENT);

to make clear that PairTestDeviceWithoutSecurity is BLE-only

@msandstedt msandstedt self-requested a review May 12, 2021 14:23
@kianooshkarami
Copy link
Contributor

Suggest adding handling of better error message for:

VerifyOrExit(peerAddress.GetTransportType() == Transport::Type::kUdp, err = CHIP_ERROR_INVALID_ARGUMENT);

to make clear that PairTestDeviceWithoutSecurity is BLE-only

@tcarmelveilleux I am a bit confused by your comment about PairTestDeviceWithoutSecurity being BLE-only, did you mean UDP-Only?

Copy link
Contributor

@kianooshkarami kianooshkarami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue

@andy31415 andy31415 merged commit f3710dd into project-chip:master May 12, 2021
@pan-apple pan-apple deleted the fix-bypass branch May 13, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pairing via Bypass (Rendezvous mode) Fails
8 participants