-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use operational credentials cluster in Commissioner #6651
Conversation
- Update ZAP to use 16 bit length for OCTET_STRING. This is a temporary hack, as it only supports 8 bit stringsconnectedhomeip/src/controller/CHIPDeviceController.cpp Lines 1088 to 1098 in 64b0cc2
This comment was generated by todo based on a
|
(#5590) We should encode a response of status code for invalid TLV.connectedhomeip/src/darwin/Framework/CHIP/gen/IMClusterCommandHandler.cpp Lines 3720 to 3730 in 64b0cc2
This comment was generated by todo based on a
|
(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.connectedhomeip/src/darwin/Framework/CHIP/gen/IMClusterCommandHandler.cpp Lines 3723 to 3733 in 64b0cc2
This comment was generated by todo based on a
|
(#5542): The cluster handlers should accept a ByteSpan for all string types.connectedhomeip/src/darwin/Framework/CHIP/gen/IMClusterCommandHandler.cpp Lines 3790 to 3800 in 64b0cc2
This comment was generated by todo based on a
|
(#5590) We should encode a response of status code for invalid TLV.connectedhomeip/src/darwin/Framework/CHIP/gen/IMClusterCommandHandler.cpp Lines 3821 to 3831 in 64b0cc2
This comment was generated by todo based on a
|
(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.connectedhomeip/src/darwin/Framework/CHIP/gen/IMClusterCommandHandler.cpp Lines 3824 to 3834 in 64b0cc2
This comment was generated by todo based on a
|
Size increase report for "nrfconnect-example-build" from 5abb72c
Full report output
|
Problem
Need to integrate operational credentials provisioning with CHIP commissioner and device apps.
Summary of Changes
This PR brings in the integration of commissioner and device code with operational credentials cluster.
The controller provisions the operational certificates as part of the provisioning.
Provisioning of trusted root will be done as a separate PR, as it needs its own cluster.
There are some TODOs in the PR that are dependent on ZAP tool updates.