Fix failure to start operational advertising #6647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checks the right maximum size
jmartinez-silabs
changed the title
jmartinez-silabs
changed the title
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jepenven-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
saurabhst
approved these changes
May 10, 2021
woody-apple
approved these changes
May 10, 2021
|
Just saw this PR #6626 |
|
Closing in favor of #6626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Starting an Advertise operational node fails with
[SVR] Failed to start operational advertising: CHIP Error 4000030 (0x003D091E): Invalid string lengthSrpClient::kMaxInstanceNameSize = 33 ([Node]-[Fabric] ID in hex - 16+1+16)
Srp client service mInstanceName is declared
char mInstanceName[kMaxInstanceNameSize];so it is missing a space for the NULL Character._AddSrpService or _RemoveSrpService fails on
VerifyOrExit(strlen(aInstanceName) < SrpClient::kMaxInstanceNameSize, error = CHIP_ERROR_INVALID_STRING_LENGTH);as it verifies < 33Summary of Changes
Add +1 for Null character. Without the Null character the srp server would fail to parse the service.
With this
VerifyOrExit(strlen(aInstanceName) < SrpClient::kMaxInstanceNameSize, error = CHIP_ERROR_INVALID_STRING_LENGTH);now accepts the full srp instance name ([Node]-[Fabric] ID in hex - 16+1+16)