Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add List[OCTET_STRING] and List[Struct{N, OCTET_STRING] support #6596

Merged
merged 5 commits into from
May 13, 2021

Conversation

vivien-apple
Copy link
Contributor

Problem

List[OCTET_STRING] or List[Struct{..., OCTET_STRING, }] support is lacking.

Summary of Changes

  • Add support for them
  • Update gen/ folders

&entryOffset, 16); // OCTET_STRING
&entryOffset, sizeof(entry->GroupKeyIndex)); // INT16U
chip::ByteSpan * GroupKeyRootSpan = reinterpret_cast<chip::ByteSpan *>(&entry->GroupKeyRoot); // OCTET_STRING
if (write && 18 < (kByteSpanInListLengthSize + GroupKeyRootSpan->size()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these auto-generated? wondering if we need constants for the 31 and 18 values and such.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are autogenerated.

@andy31415
Copy link
Contributor

Please move code that does not need to be generated into a separate h/cpp file and add unit tests.

@woody-apple
Copy link
Contributor

@vivien-apple sorry needs restyle

* limitations under the License.
*/

#include "attribute-list-helper.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would name this buffer-byte-span.h or zap-byte-span.h, to try to not use support/helper/util/tools in naming.

@vivien-apple vivien-apple force-pushed the ZAP_ListOctetString branch from 1846a8e to ff183ae Compare May 11, 2021 17:48
@vivien-apple vivien-apple force-pushed the ZAP_ListOctetString branch from ff183ae to ca469e5 Compare May 12, 2021 09:58
@vivien-apple vivien-apple force-pushed the ZAP_ListOctetString branch 2 times, most recently from 65fe828 to b786a83 Compare May 12, 2021 12:24
@github-actions
Copy link

Size increase report for "esp32-example-build" from 14461f0

File Section File VM
chip-all-clusters-app.elf .flash.text 916 916
chip-all-clusters-app.elf .dram0.bss 0 440
chip-all-clusters-app.elf .flash.rodata 416 416
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,16585
.debug_line,0,7013
.debug_loc,0,4357
.debug_abbrev,0,1854
.debug_str,0,974
.flash.text,916,916
.debug_ranges,0,640
.dram0.bss,440,0
.flash.rodata,416,416
.strtab,0,221
.debug_frame,0,160
.symtab,0,80
.debug_aranges,0,72
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,1
.shstrtab,0,-1
[Unmapped],0,-416


@bzbarsky-apple bzbarsky-apple merged commit 3cd3fea into project-chip:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants