-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add List[OCTET_STRING] and List[Struct{N, OCTET_STRING] support #6596
Add List[OCTET_STRING] and List[Struct{N, OCTET_STRING] support #6596
Conversation
eed6921
to
ee8ac89
Compare
examples/all-clusters-app/all-clusters-common/gen/attribute-size.cpp
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/gen/attribute-size.cpp
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/gen/attribute-size.cpp
Outdated
Show resolved
Hide resolved
&entryOffset, 16); // OCTET_STRING | ||
&entryOffset, sizeof(entry->GroupKeyIndex)); // INT16U | ||
chip::ByteSpan * GroupKeyRootSpan = reinterpret_cast<chip::ByteSpan *>(&entry->GroupKeyRoot); // OCTET_STRING | ||
if (write && 18 < (kByteSpanInListLengthSize + GroupKeyRootSpan->size())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these auto-generated? wondering if we need constants for the 31 and 18 values and such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are autogenerated.
examples/all-clusters-app/all-clusters-common/gen/attribute-size.cpp
Outdated
Show resolved
Hide resolved
Please move code that does not need to be generated into a separate h/cpp file and add unit tests. |
ee8ac89
to
580b10d
Compare
580b10d
to
1846a8e
Compare
@vivien-apple sorry needs restyle |
* limitations under the License. | ||
*/ | ||
|
||
#include "attribute-list-helper.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would name this buffer-byte-span.h
or zap-byte-span.h
, to try to not use support/helper/util/tools in naming.
src/app/zap-templates/templates/app/CHIPClientCallbacks-src.zapt
Outdated
Show resolved
Hide resolved
1846a8e
to
ff183ae
Compare
ff183ae
to
ca469e5
Compare
65fe828
to
b786a83
Compare
b786a83
to
34229b9
Compare
34229b9
to
b5eeb08
Compare
b5eeb08
to
cd3b292
Compare
Size increase report for "esp32-example-build" from 14461f0
Full report output
|
Problem
List[OCTET_STRING]
orList[Struct{..., OCTET_STRING, }]
support is lacking.Summary of Changes
gen/
folders