-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Zap uint16 t for attribute store" #6509
Conversation
This reverts commit 30daae2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion - @yunhanw-google - Let's investigate why/where the the python controller is mixing up this type instead of reverting spec compliant sizes, that pass cluster automation tests.
per chat @woody-apple , would hold on this revert until @vivien-apple figure out next step, thanks |
Size increase report for "nrfconnect-example-build" from 0fe16aa
Full report output
|
Size increase report for "esp32-example-build" from 0fe16aa
Full report output
|
Closing per #6531 |
Reverts #6446
Cirque device controller test is broken since this PR, in addition, real device controller test with real device is also broken since this PR. It seems this PR has been forcily merged after 3 tries on cirque tests