Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Zap uint16 t for attribute store" #6509

Closed

Conversation

yunhanw-google
Copy link
Contributor

Reverts #6446

Cirque device controller test is broken since this PR, in addition, real device controller test with real device is also broken since this PR. It seems this PR has been forcily merged after 3 tries on cirque tests

Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion - @yunhanw-google - Let's investigate why/where the the python controller is mixing up this type instead of reverting spec compliant sizes, that pass cluster automation tests.

@yunhanw-google
Copy link
Contributor Author

per chat @woody-apple , would hold on this revert until @vivien-apple figure out next step, thanks

@github-actions
Copy link

github-actions bot commented May 5, 2021

Size increase report for "nrfconnect-example-build" from 0fe16aa

File Section File VM
chip-lighting.elf text 128 128
chip-lighting.elf rodata 112 116
chip-lock.elf rodata 48 48
chip-lock.elf text 36 36
chip-lock.elf device_handles -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
text,128,128
rodata,116,112
.symtab,0,32
.debug_info,0,9
.debug_line,0,-9
.debug_loc,0,-16
.debug_str,0,-48

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
rodata,48,48
text,36,36
.symtab,0,32
.debug_info,0,9
device_handles,-4,-4
.debug_line,0,-9
.debug_loc,0,-24
.debug_str,0,-48

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


@github-actions
Copy link

github-actions bot commented May 5, 2021

Size increase report for "esp32-example-build" from 0fe16aa

File Section File VM
chip-all-clusters-app.elf .flash.text 80 80
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.text,80,80
.debug_loc,0,56
.xt.prop._ZTVN4chip24LifetimePersistedCounterE,0,2
.debug_line,0,-6
.debug_str,0,-48


@yunhanw-google
Copy link
Contributor Author

30daae2
ea5b53b
6a4fdaa
there 3 commits are broken cirque test regarding device controller for cluster validation, and real device controller against real device, you can manually trigger it via your github action

@vivien-apple
Copy link
Contributor

Closing per #6531

@woody-apple woody-apple deleted the revert-6446-ZAP_uint16_tForAttributeStore branch July 3, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants