Move lighting-app clusters from endpoint 1 to 0 #6487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
andy31415
approved these changes
May 5, 2021
woody-apple
approved these changes
May 5, 2021
saurabhst
approved these changes
May 5, 2021
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
May 5, 2021
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
May 5, 2021
…ect-chip#6487)"" This reverts commit 77f166c.
Damian-Nordic
added a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
May 19, 2021
A few changes were missed in project-chip#6487 breaking some of the lighting-app features: * initialization of clusters no longer works * events no longer work as af-gen-event.h is still not auto-generated so endpoint ID must be manually changed; as a result, setting the lighting brightness stopped working correctly.
bzbarsky-apple
pushed a commit
that referenced
this pull request
May 20, 2021
A few changes were missed in #6487 breaking some of the lighting-app features: * initialization of clusters no longer works * events no longer work as af-gen-event.h is still not auto-generated so endpoint ID must be manually changed; as a result, setting the lighting brightness stopped working correctly.
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…hip#6973) A few changes were missed in project-chip#6487 breaking some of the lighting-app features: * initialization of clusters no longer works * events no longer work as af-gen-event.h is still not auto-generated so endpoint ID must be manually changed; as a result, setting the lighting brightness stopped working correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All the lighting-app clusters are using endpoint
1. For commissioning it should normally be endpoint0(similar for the other required clusters). This PR just moves all clusters from endpoint1to0Summary of Changes
lighting-appclusters from endpoint1to0