-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete RendezvousSession, and move code to controller and server #6437
Merged
andy31415
merged 6 commits into
project-chip:master
from
pan-apple:remove-rendezvous-session
May 4, 2021
Merged
Delete RendezvousSession, and move code to controller and server #6437
andy31415
merged 6 commits into
project-chip:master
from
pan-apple:remove-rendezvous-session
May 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
sagar-apple
May 4, 2021 01:40
msandstedt
approved these changes
May 4, 2021
Size increase report for "nrfconnect-example-build" from 237cfd0
Full report output
|
woody-apple
approved these changes
May 4, 2021
sagar-apple
reviewed
May 4, 2021
sagar-apple
reviewed
May 4, 2021
sagar-apple
reviewed
May 4, 2021
msandstedt
approved these changes
May 4, 2021
andy31415
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
RendezvousSession
class functionality can be consumed by DeviceCommissioner, and RendezvousServer classes. The current logic doesn't have a lot of overlap, and will save on code size and complexity by this refactor.Summary of Changes
Move code to DeviceCommissioner, and RendezvousServer and delete RendezvousSession.