-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating TV example app to add support for on-off level control commands #6417
Updating TV example app to add support for on-off level control commands #6417
Conversation
Insert your code here to send power toggle commandconnectedhomeip/examples/tv-app/linux/include/cluster-change-attribute.cpp Lines 36 to 46 in 549a3dd
This comment was generated by todo based on a
|
Insert your code here to send mute toggle commandconnectedhomeip/examples/tv-app/linux/include/cluster-change-attribute.cpp Lines 39 to 49 in 549a3dd
This comment was generated by todo based on a
|
Insert your code here to send volume up commandconnectedhomeip/examples/tv-app/linux/include/level-control/LevelControl.cpp Lines 94 to 104 in 549a3dd
This comment was generated by todo based on a
|
Insert your code here to send volume down commandconnectedhomeip/examples/tv-app/linux/include/level-control/LevelControl.cpp Lines 99 to 109 in 549a3dd
This comment was generated by todo based on a
|
7ecd738
to
6f4648b
Compare
Problem TV example app does not support on and off commands TV example app does not support level control commands Summary of Changes - Added attribute change callback so that developper can detect on-off attribute change and implement logic for TV - Added LevelControl.cpp file so that developper can use it and change current level-control.h file. We do not need all the logic from the current level-control cluster. Handeling step command is enough. Test - Tested locally using chip-tool client and newly created tv-server - Used the zap_regen_all.py and gn_build.sh to verify the building is successful
6f4648b
to
16bb81c
Compare
Problem
TV example app does not support on and off commands
TV example app does not support level control commands
Summary of Changes
Note
Everything which is not supported by the CHIP framework currently is noted with TODO comment.
Test
./scripts/tools/zap_regen_all.py
and./gn_build.sh
to verify the building is successful