-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpCreds Fabric Management functionality #6233
OpCreds Fabric Management functionality #6233
Conversation
shana-apple
commented
Apr 22, 2021
•
edited
Loading
edited
- Adds functionality for reading the fabrics list attribute which gets updated after any updates to the admin pairing table.
- Adds functionary for removeFabric.
- Adds a setFabric command as a temporary command before AddOptCert is implemented. This allows the commissioner to set their vendorId for their fabric and returns to them their fabricId
- Remove the label field of FabricDescriptor struct because a bug in the generated code makes it that the whole list is corrupted if if is present (we need to fix whatever is wrong with OCTET_STRING in lists). This means that the UpdateFabricLabel implementation is not included in this patch.
- UI updates in the iOS demo app
src/app/clusters/operational-credentials/operational-credentials.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials/operational-credentials.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials/operational-credentials.cpp
Outdated
Show resolved
Hide resolved
29b6e7f
to
b3e6b5f
Compare
src/app/clusters/operational-credentials/operational-credentials.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials/operational-credentials.cpp
Outdated
Show resolved
Hide resolved
This needs restyling so it doesn't change every single generated file. |
2ed665e
to
a304781
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding changes requested for the storage delegate coupling - it seems we are trying to simplify ember callbacks however this introduces extra globals inside the transport layer.
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp
Outdated
Show resolved
Hide resolved
4c95e74
to
83ab43c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, however please address other comments from mspang@ and resolve conflicts.
I would also note that PRs involving generated code are very hard to review properly.
0bc73a1
to
9e29cb3
Compare
Agreed, I tend to add the regenerated files in a separate commit but we should have a script that regenerates them on push on build or something. |
41edb69
to
3bf2ced
Compare
Adds functionality for reading the fabrics list attribute which gets updated after any updates to the admin pairing table. Adds functionary for removeFabric. Adds a setFabric command as a temporary command before AddOptCert is implemented. This allows the commissioner to set their vendorId for their fabric and returns to them their fabricId Remove the label field of FabricDescriptor struct because a bug in the generated code makes it that the whole list is corrupted if if is present (we need to fix whatever is wrong with OCTET_STRING in lists). This means that the UpdateFabricLabel implementation is not included in this patch. UI updates in the iOS demo app
3bf2ced
to
aeeb165
Compare
Size increase report for "nrfconnect-example-build" from 0f443b8
Full report output
|
Size increase report for "esp32-example-build" from 0f443b8
Full report output
|
This is due to a merge conflict between PR project-chip#6233 nd PR project-chip#6442. The completion handlers got renamed to response handlers in the latter, but the former is still calling one of them completionHandler.