Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IM] Encode error status code during command dispatch. #5943

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Apr 12, 2021

Problem

We does not encode error code during dispatching commands.

Summary of Changes

Add code for encoding command responses.

The second commit is generated by

./scripts/tools/zap_regen_all.py && for x in $(gd --name-only | grep -ve '(.zap$)|(.py$)|(.gn$)'); do clang-format -i $x; done && git add examples/ src/ && gc -m "Run codegen"

@erjiaqing
Copy link
Contributor Author

@bzbarsky-apple @mspang PTAL

Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yunhanw-google
Copy link
Contributor

yunhanw-google commented Apr 13, 2021

@mspang @bzbarsky-apple ?

@erjiaqing
Copy link
Contributor Author

@mspang @bzbarsky-apple conflict resolved, PTAL.

@yufengwangca yufengwangca merged commit 689c9b5 into project-chip:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants