Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32: Fix for CMake build failure for M5Stack and rebuild. #5834

Merged
merged 3 commits into from
Apr 9, 2021

Conversation

sweetymhaiske
Copy link
Contributor

@sweetymhaiske sweetymhaiske commented Apr 7, 2021

Problem

  1. The CMake build failed for M5Stack.
  2. The CMake rebuild failure:-
    After build if we make any changes in CHIP code, it won't get reflect or compiled. We need to clean the complete build to look for the changes.

Summary of Changes

  1. Added the needed changes in /examples/common/screen-framework/CMakeLists.txt
  2. Added the fix under config/esp32/components/chip/CMakeLists.txt

Fixes #5818

@renzbagaporo
Copy link
Contributor

Does PRIV_REQUIRES suffice here?

@sweetymhaiske
Copy link
Contributor Author

Does PRIV_REQUIRES suffice here?

Done.

@dhrishi
Copy link
Contributor

dhrishi commented Apr 7, 2021

@sweetymhaiske Please check if similar changes are required in temperature-measurement-app example as it also supports M5Stack

@sweetymhaiske
Copy link
Contributor Author

@sweetymhaiske Please check if similar changes are required in temperature-measurement-app example as it also supports M5Stack

@dhrishi These changes aren't example specific.

@boring-cyborg boring-cyborg bot added the config label Apr 8, 2021
@sweetymhaiske sweetymhaiske changed the title ESP32: Fix for CMake build failure for M5Stack. ESP32: Fix for CMake build failure for M5Stack and rebuild. Apr 8, 2021
@sweetymhaiske
Copy link
Contributor Author

sweetymhaiske commented Apr 8, 2021

Added the new commit b7634d8, to overcome the issue faced during a rebuild. Initially, the changes made into the CHIP code were not getting reflected in the build unless the complete build gets cleaned.

@woody-apple
Copy link
Contributor

@sweetymhaiske Sorry, there's a conflict :(

@sweetymhaiske
Copy link
Contributor Author

@sweetymhaiske Sorry, there's a conflict :(

@woody-apple Resolved.

@andy31415 andy31415 merged commit 3ac4592 into project-chip:master Apr 9, 2021
jimlyall-q pushed a commit to jimlyall-q/connectedhomeip that referenced this pull request Apr 13, 2021
…chip#5834)

* ESP32: Fix for idf.py build failure for M5Stack

* ESP32: Fix for rebuild using idf.py (CMake).

* ESP32: Minor fixes in README.md w.r.t the CMake support added to the examples
@lijinlei2011
Copy link

hello,
When i compile esp32 CHIP demo code(..\CHIP\GitHub\connectedhomeip-master\examples\lock-app\esp32). compiling error was attached.The compiler complaints because it can't find the file "nlbyteorder.hpp".
the code is from

https://github.com/project-chip/connectedhomeip/tree/master/examples/lighting-app/esp32

Best Regards,

Ray

@sweetymhaiske
Copy link
Contributor Author

hello,
When i compile esp32 CHIP demo code(..\CHIP\GitHub\connectedhomeip-master\examples\lock-app\esp32). compiling error was attached.The compiler complaints because it can't find the file "nlbyteorder.hpp".
the code is from

https://github.com/project-chip/connectedhomeip/tree/master/examples/lighting-app/esp32

Best Regards,

Ray

Hi Ray,

In recent commit on the master branch a08f826#diff-932d9987aafff70772d3ee399cd68aa76235f6c4ab7b2fbe2bff690469dfaafeR149, they have added the fix. Can you pull the recent commits and try it once?
It works fine.

Regards,
Switi.

z-michel pushed a commit to PhysicalGraph/connectedhomeip that referenced this pull request Apr 30, 2021
…chip#5834)

* ESP32: Fix for idf.py build failure for M5Stack

* ESP32: Fix for rebuild using idf.py (CMake).

* ESP32: Minor fixes in README.md w.r.t the CMake support added to the examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32 idf.py build broken for all-clusters app
8 participants