-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Fix for CMake build failure for M5Stack and rebuild. #5834
ESP32: Fix for CMake build failure for M5Stack and rebuild. #5834
Conversation
Does |
78236e9
to
107c126
Compare
Done. |
@sweetymhaiske Please check if similar changes are required in |
@dhrishi These changes aren't example specific. |
b531ea5
to
b7634d8
Compare
Added the new commit b7634d8, to overcome the issue faced during a rebuild. Initially, the changes made into the CHIP code were not getting reflected in the build unless the complete build gets cleaned. |
@sweetymhaiske Sorry, there's a conflict :( |
b7634d8
to
836f6e7
Compare
@woody-apple Resolved. |
…chip#5834) * ESP32: Fix for idf.py build failure for M5Stack * ESP32: Fix for rebuild using idf.py (CMake). * ESP32: Minor fixes in README.md w.r.t the CMake support added to the examples
hello, https://github.com/project-chip/connectedhomeip/tree/master/examples/lighting-app/esp32 Best Regards, Ray |
Hi Ray, In recent commit on the master branch a08f826#diff-932d9987aafff70772d3ee399cd68aa76235f6c4ab7b2fbe2bff690469dfaafeR149, they have added the fix. Can you pull the recent commits and try it once? Regards, |
…chip#5834) * ESP32: Fix for idf.py build failure for M5Stack * ESP32: Fix for rebuild using idf.py (CMake). * ESP32: Minor fixes in README.md w.r.t the CMake support added to the examples
Problem
After build if we make any changes in CHIP code, it won't get reflect or compiled. We need to clean the complete build to look for the changes.
Summary of Changes
/examples/common/screen-framework/CMakeLists.txt
config/esp32/components/chip/CMakeLists.txt
Fixes #5818