Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include occupancy sensor from SiLabs #5731

Merged
merged 13 commits into from
May 19, 2021
Merged

Include occupancy sensor from SiLabs #5731

merged 13 commits into from
May 19, 2021

Conversation

markus-becker-tridonic-com
Copy link
Contributor

Problem

Occupancy Sensor/Sensing cluster is missing.

Summary of Changes

  • Imported the cluster from SimplicityStudio_v5 gecko_sdk_suite/v3.1/.
  • Moved to C++
  • Adapted to CHIP codebase.

Please check whether this code can accepted. License has been adapted similarly as the other already imported clusters.

@markus-becker-tridonic-com
Copy link
Contributor Author

FYI @jepenven-silabs @jmartinez-silabs

@restyled-io restyled-io bot mentioned this pull request Mar 31, 2021
Closed
@markus-becker-tridonic-com
Copy link
Contributor Author

Should I include a commit with the files changed by ./scripts/tools/zap_regen_all.py?

@restyled-io restyled-io bot mentioned this pull request Apr 8, 2021
Closed
@stale
Copy link

stale bot commented Apr 20, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Apr 20, 2021
@woody-apple
Copy link
Contributor

@markus-becker-tridonic-com looks like conflicts again, but also - can we add reporting to this? Reporting definitely works and is supported today.

@stale stale bot removed the stale Stale issue or PR label Apr 21, 2021
@markus-becker-tridonic-com
Copy link
Contributor Author

@markus-becker-tridonic-com looks like conflicts again, but also - can we add reporting to this? Reporting definitely works and is supported today.

will solve the conflicts.

the commented code is about out-of-the-box reporting. which seems to be bound to SiLabs code. reporting is working (verified with #6138).

@restyled-io restyled-io bot mentioned this pull request Apr 25, 2021
Closed
@markus-becker-tridonic-com
Copy link
Contributor Author

@markus-becker-tridonic-com looks like we have merge conflicts + Darwin CI is failing :(

Fixed now.

@woody-apple woody-apple dismissed bzbarsky-apple’s stale review May 7, 2021 21:24

Comments resolved

@woody-apple
Copy link
Contributor

@markus-becker-tridonic-com Sadly conflicts here :(

@woody-apple
Copy link
Contributor

/rebase

@woody-apple
Copy link
Contributor

ping @markus-becker-tridonic-com

@github-actions
Copy link

Size increase report for "esp32-example-build" from 1c2bca5

File Section File VM
chip-all-clusters-app.elf .flash.text 136 136
chip-all-clusters-app.elf .flash.rodata 104 104
chip-all-clusters-app.elf .dram0.bss 0 96
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,51874
.debug_line,0,6556
.debug_abbrev,0,3886
.debug_str,0,916
.strtab,0,202
.debug_frame,0,136
.flash.text,136,136
.flash.rodata,104,104
.dram0.bss,96,0
.symtab,0,80
.debug_loc,0,64
.debug_aranges,0,56
.debug_ranges,0,40
.shstrtab,0,-2
[Unmapped],0,-104

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

@markus-becker-tridonic-com
Copy link
Contributor Author

@woody-apple conflicts resolved and all checks passed.

@andy31415 andy31415 merged commit 7e2bbf7 into project-chip:master May 19, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@markus-becker-tridonic-com @restyled-commits
Include occupancy sensor from SiLabs (project-chip#5731)
1c0d56b 
* Add Occupancy sensor from SimplicityStudio v5

* Move to cpp

* Adapt Occupancy Sensor Server Cluster to CHIP

* Add Occupancy Sensor Server Cluster to all-clusters-app

* Add Occupancy Sensing to the list of objects with init function

* Add weak implementation of Occupancy Sensor Type

* Add occupancy-sensor-server to ESP32 build

* Restyled by whitespace

* Restyled by clang-format

* Apply review suggestions from Lukas Duda.

* Remove commented code.

* Enable OCCUPANCY_SENSING_CLUSTER/occupancy-sensor-server in zap_cluster_list.py

* Add generated modified files

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@jelderton jelderton jelderton approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@mspang mspang mspang approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@saurabhst saurabhst Awaiting requested review from saurabhst

@wehale wehale Awaiting requested review from wehale

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@LuDuda LuDuda Awaiting requested review from LuDuda

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@markus-becker-tridonic-com @woody-apple @mspang @andy31415 @LuDuda @jelderton @bzbarsky-apple @jmartinez-silabs @restyled-commits