Fix mac build by including errno.h #5323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-chip#5228 is using errno but not including the header.
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
msandstedt,
mspang,
saurabhst and
woody-apple
saurabhst
approved these changes
Mar 11, 2021
mspang
reviewed
Mar 11, 2021
| @@ -17,6 +17,7 @@ | |||
|
|
|||
| #include <stdio.h> | |||
| #include <stdlib.h> | |||
| #include <sys/errno.h> | |||
There was a problem hiding this comment.
Shouldn't it just be
#include <errno.h>
https://pubs.opengroup.org/onlinepubs/009604499/basedefs/errno.h.html
There was a problem hiding this comment.
Hmm. "man errno" was claiming <sys/errno.h> at least on Mac, but it looks like just <errno.h> works. I'll do a followup to adjust to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5228 is using
errno but not including the header.
Problem
Build fails due to missing include.
Summary of Changes
Include the header.