Rename some IM MessageDef name in code #5007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
kedars,
msandstedt,
mspang,
saurabhst and
woody-apple
yunhanw-google
force-pushed
the
feature/improve_im_message_def
branch
2 times, most recently
from
9dcecf0 to
ae763e4
Compare
bzbarsky-apple
approved these changes
Feb 24, 2021
Problems: Need to align with IM encoding spec regarding naming Summary of Changes -- Rename related words following ClusterId, DeltaUTCTimestamp, PriorityLevel, MoreChunkedMessages,SuppressResponse in spec
yunhanw-google
force-pushed
the
feature/improve_im_message_def
branch
from
ae763e4 to
f9979a8
Compare
andy31415
approved these changes
Feb 25, 2021
|
@jelderton @saurabhst ? thanks |
saurabhst
approved these changes
Feb 25, 2021
jmartinez-silabs
pushed a commit
to jmartinez-silabs/connectedhomeip
that referenced
this pull request
Feb 25, 2021
Problems: Need to align with IM encoding spec regarding naming Summary of Changes -- Rename related words following ClusterId, DeltaUTCTimestamp, PriorityLevel, MoreChunkedMessages,SuppressResponse in spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
Need to align with IM encoding spec regarding naming
Summary of Changes
-- Rename related words following ClusterId, DeltaUTCTimestamp, PriorityLevel, MoreChunkedMessages,SuppressResponse in spec