-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join multicast groups for mDNS. #4974
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes devices receive mdns queries (previously it would receive only unicast).
pullapprove
bot
requested review from
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
msandstedt,
mspang,
saurabhst and
woody-apple
February 23, 2021 14:44
Size increase report for "nrfconnect-example-build" from 5480b66
Full report output
|
Size increase report for "gn_qpg6100-example-build" from 5480b66
Full report output
|
msandstedt
approved these changes
Feb 23, 2021
Size increase report for "esp32-example-build" from 5480b66
Full report output
|
mspang
approved these changes
Feb 23, 2021
mspang
approved these changes
Feb 23, 2021
turon
approved these changes
Feb 23, 2021
jelderton
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MinMDNS was not receiving mDNS multicast queries (unicast would work and so did tests on linux because avahi was auto-joining multicast groups, but esp32 was not working).
Summary of Changes
Join IPv4 and IPv6 multicast groups. Tested on ESP32 and mdns discovery works. IPv6 on esp32 returns 'Not supported'.