Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join multicast groups for mDNS. #4974

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

andy31415
Copy link
Contributor

Problem

MinMDNS was not receiving mDNS multicast queries (unicast would work and so did tests on linux because avahi was auto-joining multicast groups, but esp32 was not working).

Summary of Changes

Join IPv4 and IPv6 multicast groups. Tested on ESP32 and mdns discovery works. IPv6 on esp32 returns 'Not supported'.

This makes devices receive mdns queries (previously it would receive
only unicast).
@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 5480b66

File Section File VM
chip-lighting.elf text 224 224
chip-lighting.elf rodata 72 76
chip-lock.elf text 228 228
chip-lock.elf rodata 80 80
chip-lock.elf shell_root_cmds_sections -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,619
.debug_loc,0,251
text,224,224
.strtab,0,198
.debug_ranges,0,168
.symtab,0,144
.debug_line,0,134
.debug_abbrev,0,111
rodata,76,72
.debug_str,0,29
.shstrtab,0,-2

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,619
.debug_loc,0,251
text,228,228
.strtab,0,198
.debug_ranges,0,168
.symtab,0,144
.debug_line,0,134
.debug_abbrev,0,111
rodata,80,80
.debug_str,0,29
.shstrtab,0,-2
shell_root_cmds_sections,-4,-4

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "gn_qpg6100-example-build" from 5480b66

File Section File VM
chip-qpg6100-lock-example.out .text 372 372
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lock-example.out and ./pull_artifact/chip-qpg6100-lock-example.out:

sections,vmsize,filesize
.debug_info,0,525
.strtab,0,449
.text,372,372
.debug_loc,0,321
.symtab,0,320
.debug_line,0,115
.debug_abbrev,0,80
.debug_frame,0,48
.debug_str,0,31
.debug_aranges,0,16
.debug_ranges,0,16
.shstrtab,0,3
[Unmapped],0,-372


@github-actions
Copy link

Size increase report for "esp32-example-build" from 5480b66

File Section File VM
chip-all-clusters-app.elf .flash.text 352 352
chip-all-clusters-app.elf .flash.rodata 72 72
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,687
.flash.text,352,352
.debug_line,0,308
.strtab,0,295
.debug_loc,0,258
.debug_abbrev,0,103
.symtab,0,80
.flash.rodata,72,72
.debug_ranges,0,56
.debug_str,0,29
.shstrtab,0,1
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,-1
[Unmapped],0,-72

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


@andy31415
Copy link
Contributor Author

@woody-apple @bzbarsky-apple ?

@andy31415 andy31415 merged commit 45e8674 into project-chip:master Feb 24, 2021
@andy31415 andy31415 deleted the join_multicast_group branch October 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants