Fix chip tool code generation does not work #4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem The zap_generate_chip.sh script does not generate the files Summary of Changes - Edited the zap_generate_chip.sh and added the new line after change directory command - Updated the controller.zap file and added content launch cluster as server
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
msandstedt,
mspang,
rwalker-apple,
saurabhst and
woody-apple
msandstedt
approved these changes
Feb 23, 2021
mspang
approved these changes
Feb 24, 2021
jepenven-silabs
approved these changes
Feb 24, 2021
jelderton
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The zap_generate_chip.sh script does not generate the files
Summary of Changes
Test
./scripts/tools/zap_generate_chip.sh./scripts/tools/zap_regen_all.pyand./gn_build.shto verify the building is successful