Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Content Launch Cluster #4953

Merged

Conversation

lazarkov
Copy link
Contributor

Problem

We do not support conent launching functionality on project-chip. We need to have a content launch cluster to be able to cover these commands.

Summary of Changes

This is boilerplate code. There will be follow up with logic update of the cluster.

  • Added content launcher cluster.xml file
  • Added content launcher server.cpp file
  • Updated example chip-tool so you can use content launcher cluster
  • Updated example tv-app so you can use it a TV server for content launcher cluster

Documentation

  • You can see the content launch cluster specification in this URL

Test

  • Tested locally using chip-tool client and newly created tv-server
  • Used the ./scripts/tools/zap_regen_all.py and ./gn_build.sh to verify the building is successful

@lazarkov lazarkov force-pushed the feature/new-content-launch-cluster branch from 0e3c7d8 to 1e6aec5 Compare February 21, 2021 15:41
Problem
We do not have content launch cluster which is needed for Chip to launch content on TV

Summary of Changes
- Added content launcher cluster.xml file
- Added content launcher server.cpp file
- Updated example chip-tool so you can use content launcher cluster
- Updated example tv-app so you can use it a TV server for content launcher cluster
@github-actions
Copy link

Size increase report for "esp32-example-build" from 2b58bdf

File Section File VM
chip-all-clusters-app.elf .flash.text 148 148
chip-all-clusters-app.elf .flash.rodata 32 32
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,13620
.debug_line,0,5216
.debug_loc,0,1985
.debug_abbrev,0,1079
.debug_str,0,969
.strtab,0,249
.debug_frame,0,208
.flash.text,148,148
.debug_ranges,0,80
.symtab,0,80
.debug_aranges,0,72
.flash.rodata,32,32
.shstrtab,0,3
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,3
[Unmapped],0,-32


@woody-apple woody-apple merged commit ab1a0bf into project-chip:master Feb 23, 2021
@lazarkov lazarkov deleted the feature/new-content-launch-cluster branch December 23, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants