[cirque] Download chip-cirque-device-base
from docker hub when available
#4940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
chip-cirque-device-base
building procedure takes ~4min.Summary of Changes
Add
--try-download
flag tochip-cirque-device-base/build.sh
The
--try-download
argument will askbuild.sh
try do download the expected version of container from dockerhub, if it does not exists, it will fall back to local build.If both
--try-download
and--latest
provided, it will tag the downloaded imagelatest
. Thescripts/tests/cirque_tests.sh
will use this two flags when running on github actions.#4845