Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cirque] Download chip-cirque-device-base from docker hub when available #4940

Merged
merged 4 commits into from
Feb 22, 2021

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Feb 19, 2021

Problem

The chip-cirque-device-base building procedure takes ~4min.

Summary of Changes

Add --try-download flag to chip-cirque-device-base/build.sh

The --try-download argument will ask build.sh try do download the expected version of container from dockerhub, if it does not exists, it will fall back to local build.

If both --try-download and --latest provided, it will tag the downloaded image latest. The scripts/tests/cirque_tests.sh will use this two flags when running on github actions.

#4845

@andy31415
Copy link
Contributor

Could you add to the description of the patch why this makes things faster?

My understanding is that downloading a prebuilt image is faster than rebuilding from scratch (which takes a very long time in our tests). This brings some questions for me:

  • why is there a 'try' there, why don't we always download?
  • what determines try result (when does the try succeed and when does it fail)?

@andy31415
Copy link
Contributor

@woody-apple @bzbarsky-apple ?
Looking forward to this - should speed up our CI presubmits a lot.

@mspang mspang merged commit ff259e0 into project-chip:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants