Update TestMessageCounterSyncMgr with the latest API change for NewPa…

[yufengwangca]

…iring

Problem

NewPairing APIs changed with #4885, which cause conflict with #4712 Implement Message Counter Synchronization Protocol part

Summary of Changes

Update TestMessageCounterSyncMgr with the latest API change.

[LuDuda]

Two more functions to align (lines 198, 204).

[msandstedt]

I still see breakages here:

michaelsandstedt@MN-MSANDSTEDT-M:~/connectedhomeip$ ninja -C out
ninja: Entering directory `out'
[0/1] Regenerating ninja files
[3/80] c++ obj/src/messaging/tests/libMessagingLayerTests.TestMessageCounterSyncMgr.cpp.o
FAILED: obj/src/messaging/tests/libMessagingLayerTests.TestMessageCounterSyncMgr.cpp.o
g++ -MMD -MF obj/src/messaging/tests/libMessagingLayerTests.TestMessageCounterSyncMgr.cpp.o.d -Wconversion -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Wextra -Wshadow -Werror -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fdiagnostics-color -fno-strict-aliasing -I/usr/local/Cellar/[email protected]/1.1.1i/include -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -DCHIP_DEVICE_CONFIG_ENABLE_CHIPOBLE=true -DLWIP_IPV4=1 -DLWIP_IPV6=1 -DLWIP_API=1 -DLWIP_ETHERNET=1 -DLWIP_SLIP=0 -DLWIP_6LOWPAN=1 -DLWIP_PPP=1 -I../src/include -I../src -Igen/include -I../config/standalone -I../src/lib -I../third_party/nlassert/repo/include -I../third_party/nlio/repo/include -I../third_party/nlfaultinjection/repo/include -I../src/lwip/standalone -I../third_party/lwip/repo/lwip/src/include -I../src/lwip/include -I../third_party/nlunit-test/repo/src -I../src/setup_payload -c ../src/messaging/tests/TestMessageCounterSyncMgr.cpp -o obj/src/messaging/tests/libMessagingLayerTests.TestMessageCounterSyncMgr.cpp.o
../src/messaging/tests/TestMessageCounterSyncMgr.cpp:198:100: error: too few arguments to function call, expected at least 5, have 4
    err = ctx.GetSecureSessionManager().NewPairing(peer, kDestinationNodeId, &pairingLocalToPeer, 0);
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                 ^
../src/transport/SecureSessionMgr.h:252:5: note: 'NewPairing' declared here
    CHIP_ERROR NewPairing(const Optional<Transport::PeerAddress> & peerAddr, NodeId peerNodeId, PASESession * pairing,
    ^
../src/messaging/tests/TestMessageCounterSyncMgr.cpp:204:95: error: too few arguments to function call, expected at least 5, have 4
    err = ctx.GetSecureSessionManager().NewPairing(peer, kSourceNodeId, &pairingPeerToLocal, 1);
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                            ^
../src/transport/SecureSessionMgr.h:252:5: note: 'NewPairing' declared here
    CHIP_ERROR NewPairing(const Optional<Transport::PeerAddress> & peerAddr, NodeId peerNodeId, PASESession * pairing,
    ^
2 errors generated.
[16/80] c++ obj/src/app/libCHIPDataModel.CommandHandler.cpp.o
ninja: build stopped: subcommand failed.

[yufengwangca]

I still see breakages here:

michaelsandstedt@MN-MSANDSTEDT-M:~/connectedhomeip$ ninja -C out
ninja: Entering directory `out'
[0/1] Regenerating ninja files
[3/80] c++ obj/src/messaging/tests/libMessagingLayerTests.TestMessageCounterSyncMgr.cpp.o
FAILED: obj/src/messaging/tests/libMessagingLayerTests.TestMessageCounterSyncMgr.cpp.o
g++ -MMD -MF obj/src/messaging/tests/libMessagingLayerTests.TestMessageCounterSyncMgr.cpp.o.d -Wconversion -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Wextra -Wshadow -Werror -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fdiagnostics-color -fno-strict-aliasing -I/usr/local/Cellar/[email protected]/1.1.1i/include -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -DCHIP_DEVICE_CONFIG_ENABLE_CHIPOBLE=true -DLWIP_IPV4=1 -DLWIP_IPV6=1 -DLWIP_API=1 -DLWIP_ETHERNET=1 -DLWIP_SLIP=0 -DLWIP_6LOWPAN=1 -DLWIP_PPP=1 -I../src/include -I../src -Igen/include -I../config/standalone -I../src/lib -I../third_party/nlassert/repo/include -I../third_party/nlio/repo/include -I../third_party/nlfaultinjection/repo/include -I../src/lwip/standalone -I../third_party/lwip/repo/lwip/src/include -I../src/lwip/include -I../third_party/nlunit-test/repo/src -I../src/setup_payload -c ../src/messaging/tests/TestMessageCounterSyncMgr.cpp -o obj/src/messaging/tests/libMessagingLayerTests.TestMessageCounterSyncMgr.cpp.o
../src/messaging/tests/TestMessageCounterSyncMgr.cpp:198:100: error: too few arguments to function call, expected at least 5, have 4
    err = ctx.GetSecureSessionManager().NewPairing(peer, kDestinationNodeId, &pairingLocalToPeer, 0);
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                 ^
../src/transport/SecureSessionMgr.h:252:5: note: 'NewPairing' declared here
    CHIP_ERROR NewPairing(const Optional<Transport::PeerAddress> & peerAddr, NodeId peerNodeId, PASESession * pairing,
    ^
../src/messaging/tests/TestMessageCounterSyncMgr.cpp:204:95: error: too few arguments to function call, expected at least 5, have 4
    err = ctx.GetSecureSessionManager().NewPairing(peer, kSourceNodeId, &pairingPeerToLocal, 1);
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                            ^
../src/transport/SecureSessionMgr.h:252:5: note: 'NewPairing' declared here
    CHIP_ERROR NewPairing(const Optional<Transport::PeerAddress> & peerAddr, NodeId peerNodeId, PASESession * pairing,
    ^
2 errors generated.
[16/80] c++ obj/src/app/libCHIPDataModel.CommandHandler.cpp.o
ninja: build stopped: subcommand failed.

There are another two places to align, updated.